From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932838AbcAHVxY (ORCPT ); Fri, 8 Jan 2016 16:53:24 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:49554 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753852AbcAHVxW (ORCPT ); Fri, 8 Jan 2016 16:53:22 -0500 From: Arnd Bergmann To: "Theodore Ts'o" Cc: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Li Xi , Jan Kara Subject: [PATCH] ext4: fix ext4_ioctl_setproject return code Date: Fri, 08 Jan 2016 22:52:44 +0100 Message-ID: <4720038.3sLXXjk50c@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:EHyPgC2ewMPbBlznAMHRec34nv318RoOKDHA1Nkors34FvaAwHV NeeV0T0ZMqWoTjxwcS5UlVBjMXlIpvceQdXpVdtgQZ/5s3kVEJwvB2qkNC+GE0IHiafsSbU JnEDryJEc2YcllYTXy6GKey+73CuKOJ2ymYMSav5VVN0Aesqi9SJACP5TZPBY0DqOU3ivRM 3vWb7vlppM1/URSZxjFvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:bH/gPzdYmyI=:FKDZM/xsqUeRALbcg3MxUg 3nf1zbNwIZuRHOa1o3WXaasbJ3ChVBhcWK+xwk9ZE320hqUUGpKqt5OB4TJx4/QcmetRIAPrA LlHEjHBwQX5HJDg7gElrm7xNXQx6mHKezdE9Gv09ENzZ9LfppsNMkoIt4NL3BkNL3kgQBGyAE 161sBFFeVVMXBWzYVrMbCZ6/xJVItgN/+FFmYY8TLEVAJNexMakzLib70SB1rEo0TqG04dx5l 2Or5LufhnkBeyYuBhClcRNsw9YDfW8G2DpFInpTulq1YFwdvZ9z/qwLKzA2dWi4KWHbhBQk25 paP5P8TF74d/fUeuPRhY0H14ePcPCdcN1IzhDKX6LjVdtgHfcFWVT/T4wzgbjOeITHJ8yN/cn G1Zun60fcH3r1RcpUQyfvQD1inJZx8+u1/dc2x+tSnn97DUNdEyfPwMLIN5Q+EuFBX/9GFEuQ KGgk2jIDVVlauZswCC7FRy2J+MwzSTaLk3f6So8GmK7i+KOfbR3kzLzHHt/xhhGjxPtJljEIB zw82uIhZdsa3kZS+b3QDtGJvjyOupi2EY0GZ+/hgInlyI5swTSjPlkanBqSQ5gcgeXOy05749 XhfBQhsZnQqBChGdV4lXUSr0N5GwQgwTGVH4not1gPI9McplaOsU59lXB39YX9tSnBnG0BpvD f/faT/VnVwvUSXuPuuh4b8+aC9sHmFkYLNAFREObRdWRAw3OddPlGBSKijv/ci4asp5ILD3TV bhk4XQYE9bux4N/H Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly introduced ext4_ioctl_setproject() functions comes in two versions, one is fine and the other has an undefined return value, as indicated by a compiler warning: fs/ext4/ioctl.c:426:1: warning: control reaches end of non-void function [-Wreturn-type] fs/ext4/ioctl.c: In function 'ext4_ioctl_setproject': This changes the function to return zero on success, as the other version does. Signed-off-by: Arnd Bergmann Fixes: e14c6dbc6429 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support") --- Found on ARM randconfig testing on the last two linux-next releases. diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index c1d45aaa7d55..946560cb3fe6 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -423,6 +423,7 @@ static int ext4_ioctl_setproject(struct file *filp, __u32 projid) { if (projid != EXT4_DEF_PROJID) return -EOPNOTSUPP; + return 0; } #endif