From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753448AbbERVTy (ORCPT ); Mon, 18 May 2015 17:19:54 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:65007 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752671AbbERVTw (ORCPT ); Mon, 18 May 2015 17:19:52 -0400 From: "Rafael J. Wysocki" To: Peter Zijlstra Cc: Linux PM list , Linux Kernel Mailing List , Thomas Gleixner , Daniel Lezcano , Len Brown Subject: Re: [PATCH 2/2] PM / sleep: Make ->enter_freeze callbacks depend on CONFIG_SUSPEND Date: Mon, 18 May 2015 23:45:10 +0200 Message-ID: <4721283.2H3KXdSq7L@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.0.0+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150518121826.GG21418@twins.programming.kicks-ass.net> References: <7138791.PFSSF2gqXk@vostro.rjw.lan> <2834114.lD6BFXhtqK@vostro.rjw.lan> <20150518121826.GG21418@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, May 18, 2015 02:18:26 PM Peter Zijlstra wrote: > On Sat, May 16, 2015 at 01:38:48AM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The ->enter_freeze callbacks of cpuidle drivers are only used if > > CONFIG_SUSPEND is set, so make them explicitly depend on that > > Kconfig option. > > No real objection, but is it worth it to sprinkle that CONFIG stuff over > all drivers? Well, you maybe right that it isn't. The footprint is small anyway. What about [1/2]?