From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161131AbdKQRqK (ORCPT ); Fri, 17 Nov 2017 12:46:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50122 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030310AbdKQRqA (ORCPT ); Fri, 17 Nov 2017 12:46:00 -0500 Subject: Re: [GIT PULL] usercopy whitelisting for v4.15-rc1 To: Linus Torvalds , Kees Cook Cc: David Windsor , Linux Kernel Mailing List References: <20171117165423.GA34980@beast> From: Paolo Bonzini Message-ID: <47222b54-cb13-2362-a525-714be2ba96de@redhat.com> Date: Fri, 17 Nov 2017 18:45:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 17 Nov 2017 17:46:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/11/2017 18:35, Linus Torvalds wrote: > Honestly, I'm unlikely to pull this at all this merge window, simply > because I won't have time for it. This merge window is not going to be > one where I can take a leisurely look at something like this. > > If you can make a smaller pull request that introduces the > infrastructure, but that _obviously_ cannot actually break anything, > that would be more likely to be palatable. As someone that was actually bitten by this stuff, and had a closer look at the usercopy whitelisting stuff... This one is really fail-fast (oopses all around if you forget to patch something), and with hardly any configuration dependency. It's certainly a lot less scary to me than the GCC plugin stuff. But I don't want to ruin your Thanksgiving, so if Kees and/or you choose not to do this pull request---please do pull a subset, even after -rc1. It's easy enough to drop the final patch that changes whitelisting to blacklisting, and it'd be one less series bouncing around and touching files in several subsystems. My 2 cents, Paolo