From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751479AbdJVKCV (ORCPT ); Sun, 22 Oct 2017 06:02:21 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:49017 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbdJVKCU (ORCPT ); Sun, 22 Oct 2017 06:02:20 -0400 X-Google-Smtp-Source: ABhQp+TKtl7eA2pqDTKGQhL10jyxWvGv12oDADamghUq5sAtd2E5wRlCqj2Zwcw22TnDG+0TRGcjcw== Subject: Re: [PATCH 2/2] soc: mediatek: pwrap: fix fatal compiler error To: Sean Wang Cc: chenglin.xu@mediatek.com, chen.zhong@mediatek.com, arvind.yadav.cs@gmail.com, christophe.jaillet@wanadoo.fr, robh@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20171021082529.31351-1-matthias.bgg@gmail.com> <20171021082529.31351-2-matthias.bgg@gmail.com> <1508646191.29850.23.camel@mtkswgap22> From: Matthias Brugger Message-ID: <4722c8ca-b967-7f35-8c8c-f718f40612a2@gmail.com> Date: Sun, 22 Oct 2017 12:02:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1508646191.29850.23.camel@mtkswgap22> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/2017 06:23 AM, Sean Wang wrote: > On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote: >> When adding the MT6380 compatible, the sentinel for of_device_id was >> deleted, which leades to the following compiler error: >> FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry! >> >> Fix this by adding the sentinel again. >> >> Signed-off-by: Matthias Brugger >> --- >> drivers/soc/mediatek/mtk-pmic-wrap.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c >> index 912edf93c192..e9e054a15b7d 100644 >> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c >> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c >> @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = { >> }, { >> .compatible = "mediatek,mt6397", >> .data = &pmic_mt6397, >> + }, { >> /* sentinel */ >> } >> }; > > Thanks for patching the mistaken edit I made. > > Acked-by: Sean Wang > > Thanks, both patches pushed to v4.14-next/soc