From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Matthew Wilcox <matthew@wil.cx>
Cc: James.Bottomley@SteelEye.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean
Date: Tue, 30 Oct 2007 16:02:25 +0100 [thread overview]
Message-ID: <47274781.3030606@student.ltu.se> (raw)
In-Reply-To: <20071030145155.GL32359@parisc-linux.org>
Matthew Wilcox wrote:
> On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote:
>
>> Convert to use the generic boolean.
>> - u8 initialized;
>> - u8 in_use; /* is the management node open*/
>> + bool initialized:8;
>> + bool in_use:8; /* is the management node open*/
>>
>
> Are you serious?
>
Well, yes. It is since it was defined to really be 8 bits before, and
there is no reason why a boolean would be 8 bits and not 1 or 16.
If it is overly cautious/not needed, then I don't mind removing the ':8'...
Richard Knutsson
next prev parent reply other threads:[~2007-10-30 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 10:54 Richard Knutsson
2007-10-30 14:47 ` Salyzyn, Mark
2007-10-30 14:51 ` Matthew Wilcox
2007-10-30 15:02 ` Richard Knutsson [this message]
2007-10-30 15:11 ` Matthew Wilcox
2007-10-30 16:46 ` Richard Knutsson
2007-10-30 17:38 ` Matthew Wilcox
2007-10-30 20:52 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47274781.3030606@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome