From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752654AbbJSM5P (ORCPT ); Mon, 19 Oct 2015 08:57:15 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:59150 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbbJSM5N (ORCPT ); Mon, 19 Oct 2015 08:57:13 -0400 From: Arnd Bergmann To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Peter Hurley , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Subject: Re: [PATCH] tty/serial: make early console depend on SERIAL_CORE=y Date: Mon, 19 Oct 2015 14:56:59 +0200 Message-ID: <4727600.4io7e2HWRP@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1445206009-12275-1-git-send-email-paul.gortmaker@windriver.com> References: <1445206009-12275-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:jlJmeF0/Pf7ibvYVXrxy4DSjDK6NxfgOVvoDDrYjcOD51Cuy6pi 38AP4EqUtVlE15tYvShdl95pVjLI4/xvFRfm9RDNMvT6L4LojpxLmRvzKXqAGzR/GykuJ9w IZhDy4jzAvsTIZs3n1U1KJhcoWJhBWykOx2aXPOapCLehxkROek8IiuSxAybcbPeQVcFjR8 5+ppiMCV55IH92ZmkQs+g== X-UI-Out-Filterresults: notjunk:1;V01:K0:iREgdsZFSv8=:S9y3pKWaCfkM/7VHsO1Md+ au7qmWDWSfQwgiwfR4RaGNM4wLDN6ecIjL2Uvi4o26NYzV/eb4EUKzd4/dGZXx6N42Uhvt+D+ iTgo8i3JTkm2pvRoafpD2ItYfFPFifQLzs5sH6F2MFmvQLKAIOR2d20kMX8mQR1ZnuGBSsgvN SRs05j6n4StSV4p6mTMtM5WBeUN2HDB775LQosOn/f7hwBVT55mLa7HCUVdT5pDLyKr9B8Vq1 uNrH/cW7x73DJYd12YDqNechRsmD/L272hEbOPYahOCUdD7XqIztHWmvN/iBE6TKZSr4JkzAD crlPp4Hm9BBa2Ho+E4a/6i6AWW8JvaWRV0E4BncAUsR+6pxIJCdKnNOV+Ct4A3IX8oUGI5HP7 PiO0iZRqjrgZk/ln85FHXN4LECwRKDRgvVSUu1yfUhaGqJGeif/cRcZwS2tx1n22eILNdnbj8 da2zPcyJsf0J5TyX5ao/uAE+bdPBPL9gFoCtsQGpDEqxauofbxIWRVpc0UpsVbC3kwq2lMeBF Jrxf+0r7XSuyMZ2kTjMrPscz7gzDztETdu9dUJycoQQv+OVKVyODrkoBTB7kS76t7RsXOK43T +st8p0ALHDTqsY78RtI3lzhI2qNLdvIoDgisza1WXwRThEJ9DZHSfFXpSC745vWB2aftXddRk pZT0t0A8kFRS6rjk0E7lQH/L6WawTv1jlwCi9DKQaN89LbqN0lH96VdVh6LoFJGhlu1/GjJHi A/h7F6ynDN0WoMoD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 18 October 2015 18:06:48 Paul Gortmaker wrote: > On an powerpc allmodconfig build, the following is seen: > > paul@builder:~/git/linux-head$ make O=../ppc-build -j30 > /dev/null > drivers/built-in.o: In function `.setup_earlycon': > (.init.text+0x5b00): undefined reference to `.uart_parse_earlycon' > make[1]: *** [vmlinux] Error 1 > > Since uart_parse_earlycon lives in serial_core.c we need to ensure > it is built in if early console is to be used. I saw the same thing and came up with a different fix > Cc: Arnd Bergmann > Cc: Peter Hurley > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-serial@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > > [A google shows this cropped up in April of this year; I guess it wasn't > completely fixed? > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-April/336954.html > FWIW, I was testing on tty/tty-testing pulled today, from Greg ] The new problem was clearly caused by 1d59b382f1c4 ("serial: fsl_lpuart: add earlycon support"), which selects SERIAL_EARLYCON but not SERIAL_CORE_CONSOLE. However, the way I read Peter's patch from the URL you provided, it seems that it is supposed to work without my patch, so I'm not sure. Arnd >>From 8b8704525b47ba3287de2d7ff89a53e3e335f9d8 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Mon, 19 Oct 2015 13:02:08 +0200 Subject: [PATCH] serial: fsl-lpuart: select SERIAL_CORE_CONSOLE drivers/built-in.o: In function `setup_earlycon': :(.init.text+0x2c4c): undefined reference to `uart_parse_earlycon' Signed-off-by: Arnd Bergmann diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 1aec4404062d..f1a4f9eccc44 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1540,6 +1540,7 @@ config SERIAL_FSL_LPUART depends on HAS_DMA select SERIAL_CORE select SERIAL_EARLYCON + select SERIAL_CORE_CONSOLE help Support for the on-chip lpuart on some Freescale SOCs.