mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Cristian Deluxe <me@cristiandeluxe.dev>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] wifi: rtw88: 8703b: stop the PCIe DMA write reaching SDIO
Date: Sun, 13 Sep 2026 02:49:09 +0000	[thread overview]
Message-ID: <47279427012044d4afab9b0e76c03ce4@realtek.com> (raw)
In-Reply-To: <178914109042.64584.11316164845616306056@cristiandeluxe.dev>

Cristian Deluxe <me@cristiandeluxe.dev> wrote:
> The first entry of trans_act_to_lps_8703b writes 0xff to MAC register
> 0x301 on every interface. That register is the PCIe DMA control, and
> both trans_act_to_lps_8723d and Realtek's own 8703b sequence header
> restrict the same entry to PCI, where it is commented "PCIe DMA stop".
> 
> So on an RTL8723CS, which is SDIO only, every transition into low power
> poked a PCIe register for no reason. Restrict it the way the sibling
> chip and the vendor both do.
> 
> Tested on an RTL8723CS over SDIO: the interface goes down and back up,
> reassociates and takes an address, and a warm reboot brings Wi-Fi back
> with no change in behaviour.
> 
> Signed-off-by: Cristian Deluxe <me@cristiandeluxe.dev>

Checked. The settings are identical to vendor driver.

Acked-by: Ping-Ke Shih <pkshih@realtek.com>


      reply	other threads:[~2026-09-13  2:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 15:38 [PATCH 0/2] wifi: rtw88: 8703b: repair the card-disable transition Cristian Deluxe
2026-09-11 15:38 ` [PATCH 1/2] wifi: rtw88: 8703b: complete the card-disable to card-emulation transition Cristian Deluxe
2026-09-13  2:44   ` Ping-Ke Shih
2026-09-16  5:30   ` Ping-Ke Shih
2026-09-11 15:38 ` [PATCH 2/2] wifi: rtw88: 8703b: stop the PCIe DMA write reaching SDIO Cristian Deluxe
2026-09-13  2:49   ` Ping-Ke Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47279427012044d4afab9b0e76c03ce4@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=me@cristiandeluxe.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®