From: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
To: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch v002] gcov: Added support for >=gcc-6
Date: Fri, 1 Jul 2016 12:58:47 +0200 [thread overview]
Message-ID: <47279bc9-d179-5c14-3fce-ed88135e6bea@linux.vnet.ibm.com> (raw)
In-Reply-To: <CACBfHbx-XC2nUMmqda+Az1L7muzCCyN_1gPKZjPRa8Hd9RRYzw@mail.gmail.com>
On 01.07.2016 11:06, Florian Meier wrote:
> Signed-off-by: Florian Meier <Florian.Meier@informatik.uni-erlangen.de>
> ---
> kernel/gcov/gcc_4_7.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gcov/gcc_4_7.c b/kernel/gcov/gcc_4_7.c
> index e25e92f..6a5c239 100644
> --- a/kernel/gcov/gcc_4_7.c
> +++ b/kernel/gcov/gcc_4_7.c
> @@ -18,7 +18,7 @@
> #include <linux/vmalloc.h>
> #include "gcov.h"
>
> -#if __GNUC__ == 5 && __GNUC_MINOR__ >= 1
> +#if (__GNUC__ > 5) || (__GNUC__ == 5 && __GNUC_MINOR__ >= 1)
> #define GCOV_COUNTERS 10
> #elif __GNUC__ == 4 && __GNUC_MINOR__ >= 9
> #define GCOV_COUNTERS 9
>
Content looks good but the patch doesn't apply due to whitespace issues.
Could you send a version with the tabs remaining intact? Also a slightly
more verbose patch message (similar to the one of the original patch)
would be helpful.
--
Peter Oberparleiter
Linux on z Systems Development - IBM Germany
next prev parent reply other threads:[~2016-07-01 10:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 9:06 Florian Meier
2016-07-01 10:58 ` Peter Oberparleiter [this message]
2016-07-01 13:09 ` [PATCH v003] Added support for gcc version >= 6 Florian Meier
2016-07-01 15:46 ` Peter Oberparleiter
2016-07-01 16:26 ` Joe Perches
2016-07-04 7:43 ` Peter Oberparleiter
2016-07-04 7:56 ` Florian Meier
2016-07-04 8:19 ` [PATCH v004] gcov: " Florian Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47279bc9-d179-5c14-3fce-ed88135e6bea@linux.vnet.ibm.com \
--to=oberpar@linux.vnet.ibm.com \
--cc=Florian.Meier@informatik.uni-erlangen.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®