From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751663AbdAMXLn (ORCPT ); Fri, 13 Jan 2017 18:11:43 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34331 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751482AbdAMXLm (ORCPT ); Fri, 13 Jan 2017 18:11:42 -0500 Subject: Re: [PATCH] platform/x86: Add IMS/ZII SCU driver To: Darren Hart , Andy Shevchenko References: <20170111212644.9217-1-f.fainelli@gmail.com> <20170113182242.GA17467@localhost.localdomain> Cc: Platform Driver , cphealy@gmail.com, Guenter Roeck , open list From: Florian Fainelli Message-ID: <47290232-c049-94ab-7b79-4c0c982b2803@gmail.com> Date: Fri, 13 Jan 2017 15:11:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170113182242.GA17467@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/13/2017 10:22 AM, Darren Hart wrote: >> Btw, Darren, would it be good idea to start creating folders to make a >> bit of order in the subsystem? For first I would move Intel's PMIC/SCU >> stuff to somewhere (not sure if it should be per manufacturer or per >> function). > > If we create folder, I'd recommend by manufacturer as that is typically along > the lines that our contributors work. Someone with a Dell laptop tends to focus > on Dell. The Intel engineers will focus primarily on Intel SoCs, etc. > > I'd like to avoid getting too granualar as it adds overhead with Makefiles, > file navigation, etc. Any thoughts on a minimum file count to justify a new > directory? Maybe 5? Chris would be in a better position than I am to comment whether up to 5 x86-based designs from ZII could show up, how about we start with naming this file zii_scu.c, keep it under drivers/platform/x86/ for now, and if we have 4 more (or less, whatever the threshold is), then we create a zii/ directory and move this one (and the new ones) there? -- Florian