From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5381DC4167B for ; Tue, 28 Nov 2023 09:19:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234788AbjK1JTL (ORCPT ); Tue, 28 Nov 2023 04:19:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230044AbjK1JTJ (ORCPT ); Tue, 28 Nov 2023 04:19:09 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 926D8D4C for ; Tue, 28 Nov 2023 01:19:15 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-332e3664665so3130607f8f.0 for ; Tue, 28 Nov 2023 01:19:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701163154; x=1701767954; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=BJ3V0q0kN4dcJ19Ow1ceuBEQfKiUYtgJ8KZQRLu90zA=; b=Ll1tKu3b9mBSOigmYdrVu9XXX0V5bFef3nrRDHyct+FCyFypmRHJpA1Ay18kQj36RN 3uXBTSdfsyxJmveFi06DvIc/YOoaasYqpXnW5QmTucfVCXRVA84B7vcyHEl5/CPe3Wdx zMOog2MkfCeIRdRVNyUe6+yWKEsWVnI/DiAkVvqLLbs0Jh1XuRlmO2tkp/vf3InKUvgb M0lZMVuRIdTjobpQxQj93QAk6DuMjFj+TtyiAYWMWwJMMc7JUH4pT2Kk6u6llky6Q3vW R9hkQLy+rB3ZHUbop36UIAxwNkI9qX44wCi2EjbbVDJ1k2mexc2lpMHT/v70YvIy8qRo 3CUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701163154; x=1701767954; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:content-language:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BJ3V0q0kN4dcJ19Ow1ceuBEQfKiUYtgJ8KZQRLu90zA=; b=AayafBt6x/oKv3wYLD87ndhdu27A2ozQ2jv4wCuxJCSYTLTNRW0F9JQ2skZ+ZAFsfb dzRyVI2IrnPv9Bj5MEZj1Z69WkiXMZO77xXRY1qqY4KiESBMw3QvXCI3fya1J9x1WYkV /WrvNeiHU45ZbRew+Kf/j498Ws/1XghQ7Ze+p3Yq0y9+HOlrnG0MRavGxhbscvyt7u7+ 0qI+sw2sQh94p84wzZnMdj2bu8DAqn1T4pkCvb4X2b4bzRFO4iRrbZeXaR2yB+0Uy5X5 4sRNXa0CYVhLwTnosi7ygL76LpmoZCninXHgJOGPt/C9Ex+kMX6ezIu3vznycEvWwerI JllA== X-Gm-Message-State: AOJu0YwAAMoxB+9i+uicaJAUcRREFO4Id8i/HH9HN0JP/uMiVpge/jNC 6lxh+N6tfxn487fJkygCcyt5Tg== X-Google-Smtp-Source: AGHT+IHOfqxAei4iLmLAMcsBFKePLmqMHOvd2JuyfofyNDEoVDltsc/kP1OjmEoERRPKcIoS7BlNaQ== X-Received: by 2002:adf:f387:0:b0:332:e61d:4b84 with SMTP id m7-20020adff387000000b00332e61d4b84mr7953763wro.21.1701163153992; Tue, 28 Nov 2023 01:19:13 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:eada:f40e:7ab3:2afe? ([2a01:e0a:982:cbb0:eada:f40e:7ab3:2afe]) by smtp.gmail.com with ESMTPSA id d15-20020adff84f000000b00333097fc050sm1872064wrq.1.2023.11.28.01.19.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Nov 2023 01:19:13 -0800 (PST) Message-ID: <4729f36a-2cf8-423d-87e1-1733a9062bd4@linaro.org> Date: Tue, 28 Nov 2023 10:19:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 2/5] ASoC: dt-bindings: document WCD939x Audio Codec Content-Language: en-US, fr To: Krzysztof Kozlowski , Srinivas Kandagatla , Banajit Goswami , Andy Gross , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231123-topic-sm8650-upstream-wcd939x-codec-v1-0-21d4ad9276de@linaro.org> <20231123-topic-sm8650-upstream-wcd939x-codec-v1-2-21d4ad9276de@linaro.org> <160fc6c4-b07d-49c5-976b-aa0fa35e4f0f@linaro.org> <60c9ba5d-a2b8-43cd-8b8d-2c709b8e5d04@linaro.org> <752f5347-703a-4b38-b2b1-3493d270389c@linaro.org> <91528bf4-c971-415e-afb4-51791c6dfc91@linaro.org> Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <91528bf4-c971-415e-afb4-51791c6dfc91@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/11/2023 10:17, Krzysztof Kozlowski wrote: > On 28/11/2023 10:14, neil.armstrong@linaro.org wrote: >>> >>> Here the device exposes its version in registers, so you can easily rely >>> on the compatibility. That's also the case multiple times talked on the >>> mailing lists. >> >> ... you're right here version can be determined at runtime. >> >> But, since both are compatible, there's no primary part number, right? >> >> so why use "qcom,wcd9395-codec", "qcom,wcd9390-codec" > > This one, please. Ok > >> when "qcom,wcd9390-codec", "qcom,wcd9395-codec" should >> also be valid, so in this can why not use : > > Could be valid, sure, but we are humans and we treat higher number as > something newer or bigger, thus previous one feels more natural. There > are examples of this way, though. > > >> "qcom,wcd9390-codec", "qcom,wcd939x-codec" >> or >> "qcom,wcd9395-codec", "qcom,wcd939x-codec" > > This not, because wildcards are not allowed in the compatibles. In the > past there were examples how a wildcard stopped being wild, so guideline > is: just don't use them. > > Best regards, > Krzysztof > Thanks, Neil