mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Yangtao Li <frank.li@vivo.com>,
	clm@fb.com, josef@toxicpanda.com, dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove BTRFS_REF_LAST from btrfs_ref_type
Date: Tue, 15 Apr 2025 18:13:16 +0930	[thread overview]
Message-ID: <472ae717-5494-44ae-973a-85249a65d289@gmx.com> (raw)
In-Reply-To: <20250415083808.893050-1-frank.li@vivo.com>



在 2025/4/15 18:08, Yangtao Li 写道:
> It seems that it has never been used, so remove it.

History please.

> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>   fs/btrfs/delayed-ref.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/btrfs/delayed-ref.h b/fs/btrfs/delayed-ref.h
> index f5ae880308d3..78cc23837610 100644
> --- a/fs/btrfs/delayed-ref.h
> +++ b/fs/btrfs/delayed-ref.h
> @@ -262,7 +262,6 @@ enum btrfs_ref_type {
>   	BTRFS_REF_NOT_SET,
>   	BTRFS_REF_DATA,
>   	BTRFS_REF_METADATA,
> -	BTRFS_REF_LAST,

The _LAST or _NR suffix can be utilized to do sanity checks, and this is 
not part of the on-disk format.

And if this exposed by some automatic tools, please also mention it.

>   } __packed;
>   
>   struct btrfs_ref {


  reply	other threads:[~2025-04-15  8:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15  8:38 Yangtao Li
2025-04-15  8:43 ` Qu Wenruo [this message]
2025-04-15  8:56   ` 回复: " 李扬韬
2025-04-15  9:16     ` Qu Wenruo
2025-04-15 15:46       ` Sun YangKai
2025-04-15 16:05       ` David Sterba
2025-04-16 13:25         ` 回复: " 李扬韬
2025-04-16 19:18           ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472ae717-5494-44ae-973a-85249a65d289@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=frank.li@vivo.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®