From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A845CC001B3 for ; Fri, 23 Jun 2023 12:35:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229484AbjFWMfE (ORCPT ); Fri, 23 Jun 2023 08:35:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbjFWMfA (ORCPT ); Fri, 23 Jun 2023 08:35:00 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8DF983 for ; Fri, 23 Jun 2023 05:34:49 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3fa70ec8d17so16899155e9.1 for ; Fri, 23 Jun 2023 05:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687523688; x=1690115688; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=j1yZaWJGe9IcIKWNFpQUcAmfs5rS4cwacSwQxYTHl74=; b=GqNLDhDRTN6ok7PjO865yX7X3mT/Pb35GyUvaH6DePu01cUCOMxDbFwXI3LW/EoYZ3 pKYniy2LaU83C7AdOUrghfd89pQbqxU1zh0i1yHzgKLFYzK9i8jYT+YsB0KG8DE/DA10 pWOMsGunZ7GTpdNRQewlPEH4WyUnv9j4sedqUhKncv+1wI+5FEZq6EaOvwPpvoAkF1us gIkMZFR1pnCg1/YPb+wXpEuFTnMpi9cxC9JaR+sA0BwCRDfu45CeOws0/ma0Uohzxs4w nq0kLPupebWozyr4gM94xrPp8zeCX/DjwEri5XVVtJTneRCF+2U3EKDOABXRTiHoiYb8 uWSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687523688; x=1690115688; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j1yZaWJGe9IcIKWNFpQUcAmfs5rS4cwacSwQxYTHl74=; b=huLZPeeWoaqaOqzajZkn69LUDD/PIUoeg9g71hyClV+fHcJnDt76v7rx0jVojVW0LQ vHMYRFqEqVab+fPatwXoWcxfxQQNDRv4lTB+zv9rPUvSnBPvdB6VyUT8VAtHpi4jDf5c YHX2uuOeBGJZB1Sy53PaX1+YpM5/ox2kOclfjkEYO8P3pADWxfLw0Jrkpq1NG5eZpQeO pb584MJqTbdjgBSS0NLV7E9aIhsqDPNf6kz6LvkDYdq3xgL4K0HpWkLoV/ljJUuZ1oAl AhT7aqTKLh8u357JwQOyHLQgID0FWizYRCaXy/PuybCjsfF9wn41b5gbOF1wI44lQpjZ iBBQ== X-Gm-Message-State: AC+VfDz4aGMtVHzW+0hlIhE7S7DAaZxpjZMyR2NM2mBClRJDweeu+xYq foune5LdDZ4GD9pKaENWPEU4dA== X-Google-Smtp-Source: ACHHUZ5yeHlhiQmXZLa1mYovHiOgvXzYqqfZRMhfDDvQP9zdkIqqawnzDkpqqWGh/UDGyzaIZZcDsg== X-Received: by 2002:a05:600c:861a:b0:3fa:77b0:263d with SMTP id ha26-20020a05600c861a00b003fa77b0263dmr3876640wmb.14.1687523688208; Fri, 23 Jun 2023 05:34:48 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id t23-20020a7bc3d7000000b003f9b0f640b1sm2250520wmj.22.2023.06.23.05.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 05:34:47 -0700 (PDT) Message-ID: <472d7c85-2b73-aa7d-b060-5a1a87580f15@linaro.org> Date: Fri, 23 Jun 2023 14:34:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/5] scsi: dt-bindings: ufs: qcom: Add compatible for sm6115 and sm6125 Content-Language: en-US From: Krzysztof Kozlowski To: Abel Vesa , Manivannan Sadhasivam , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Martin K . Petersen" , Alim Akhtar , Avri Altman , Bart Van Assche , Lux Aliaga , Iskren Chernev Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List References: <20230623113009.2512206-1-abel.vesa@linaro.org> <20230623113009.2512206-3-abel.vesa@linaro.org> <1e66ae2e-d88d-7c7f-a42f-e4ba17fd254e@linaro.org> In-Reply-To: <1e66ae2e-d88d-7c7f-a42f-e4ba17fd254e@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/06/2023 14:33, Krzysztof Kozlowski wrote: > On 23/06/2023 13:30, Abel Vesa wrote: >> Add the compatible string for the UFS on sm6115 and sm6125 platforms. >> >> Signed-off-by: Abel Vesa >> --- >> .../devicetree/bindings/ufs/qcom,ufs.yaml | 32 +++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> index bdfa86a0cc98..46f454ec3688 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >> @@ -29,6 +29,8 @@ properties: >> - qcom,sa8775p-ufshc >> - qcom,sc8280xp-ufshc >> - qcom,sdm845-ufshc >> + - qcom,sm6115-ufshc >> + - qcom,sm6125-ufshc >> - qcom,sm6350-ufshc >> - qcom,sm8150-ufshc >> - qcom,sm8250-ufshc >> @@ -163,6 +165,36 @@ allOf: >> minItems: 2 >> maxItems: 2 >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,sm6115-ufshc >> + - qcom,sm6125-ufshc >> + then: >> + properties: >> + clocks: >> + minItems: 8 >> + maxItems: 8 >> + clock-names: >> + items: >> + - const: core_clk >> + - const: bus_aggr_clk >> + - const: iface_clk >> + - const: core_clk_unipro >> + - const: ref_clk >> + - const: tx_lane0_sync_clk >> + - const: rx_lane0_sync_clk >> + - const: ice_core_clk >> + reg: >> + minItems: 2 >> + maxItems: 2 >> + reg-names: >> + items: >> + - const: std >> + - const: ice > > Same comment about reg-names as for your further patch. > > I guess this will supersed the > https://lore.kernel.org/all/20221215190404.398788-1-they@mint.lgbt/ > (because it was abandoned... I keep rebasing this patch for half a year) > The 6115 is even older - from October: https://lore.kernel.org/all/20221030094258.486428-2-iskren.chernev@gmail.com/ Let's go with your patch, but you anyway need to fix reg-names. Best regards, Krzysztof