From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44C9D2D47EF for ; Mon, 2 Feb 2026 10:12:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770027152; cv=none; b=ah151oMfX6hPiGCJezp9zOlAJFu4K0gx+2HshX1Zh5izMxRj+kCQ+0FV2bGAYNh3Ho1bDylhSAEoIn/MfEhyuHm2CgksJKSXqsoq1OqIPrJgVvQY4RDqSR0OdeiquhaBPGrFtWKE6Owxv/rf0rtmS+wbkBBaS/Qkwn/kl8ijZeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770027152; c=relaxed/simple; bh=iFMbqwctJwHkJZqPrzS51Pz2muts4JJsycPay0HzPyY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JHKDqZzvGohFRwzsvtTU1JUslfs6LLIfLF/QCWA8OsMisq0iwfmvd5xboNmhLMvObkvoqnrZ8Omjq9dfVmltRJ4rleT3evq21SdSOsDnMOpjyu9DnhGC5P+RSlXWm6KaxfXZHG0l/DJ2zj3l8mNT8YaYZMsvxLBa6H9leycBom8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y1VZ/D5e; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YNg4Afj9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y1VZ/D5e"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YNg4Afj9" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61281pu31096156 for ; Mon, 2 Feb 2026 10:12:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tHS6Wu5wR7F9TxmgaA02/LdYSXLSsQ7GX/XD1ERtU48=; b=Y1VZ/D5e6wIoYfpM UTB2YvYYdbFnZwPc9SBGl/VicNsY1Wkoiq7JVtc1WzShEc6FTVcs3B32tysDzyGq Jo2yLNeVamNumrbzAbl8mWvWWG4RdI6k2S0nV7vFv0hKLhrPmHbhSJNVAd7j5Pgn JJMWvUeuWr+j+Gn+Dk6TU8yHN8JKURUveU//CohN/s9vOkLKNeRE60gu8plXADZf NlOcsupYC/VuZ7LFolJlKbJicgyqZdy2Z7+1iNl3lMtRbR7g7EioBUYAusIRuFJE qvTPXzeWzsQHNI07Qvch5kB8TjgHYDlm2iGRz1Ya6H0Y4qzwcrAboKSb4+yKiVuX nj96tA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c1arrvyf9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 10:12:30 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c53892a195so60757285a.3 for ; Mon, 02 Feb 2026 02:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770027149; x=1770631949; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tHS6Wu5wR7F9TxmgaA02/LdYSXLSsQ7GX/XD1ERtU48=; b=YNg4Afj9DURD0ScxsbhTW0Mo/Vg2gVkNkbSZKdBu1wR0mU+YF5lB01JdmrrrSRg9S6 5ycBxocXe4YK8zc1tAM8X/yRVniJBfTmHVNAnl1riwr6CX5hYO3llCwlPXKWRvw9IUwF qHXp9q2Tei8/Pbo2H0t8Xw2mA8vJ7hcot+hbPv6kGZglvvNEfU/eSZiRivW3yYfsvOqW 8lNHTpaW59/53BTCck6XjVgOGgYdrqXNFNo1ro1r4rSFLIu134lLATffnYS07rFWbGpo 3MGhoyxNN4BF5VM5BGeouzsym1lbAtpCLM70CtRYYBnCX5PpRNmWTku6pRJTi38Ah7ux AMag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770027149; x=1770631949; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tHS6Wu5wR7F9TxmgaA02/LdYSXLSsQ7GX/XD1ERtU48=; b=wvT9g6yY+tadBAINCb7I0yfgihS96nuJg4Mjuvq8n6rIFafgLuTtI0fvLrYZCKS7rY gKXBEB+gzxEoCnHUqv804iupabCA8Md94a6Od20roIQby+4oYveQw2icfWX6TAVGeLhh NrPj1zVsiGnvQJ1qgtglX1esg/aB46XimBVm2+ZTQ1s2C2S2yuXV2Sv/iuifT7OyYicL Dl86vobgwuk+kfyf4CcsmsN/fUxM+WGHJBtSMyN/HAtz3ugirRmlMl7chSDsMtP98qGW FFRfCTiYNhpzyAfvGN0JMIvoyXZzeb+g8Qg+NkFJLNV/1dtBEE4+qCQYZPtHskteiMoY ou+g== X-Forwarded-Encrypted: i=1; AJvYcCWsOhENf3eCPIu1/YrTeEEYc7FkK2ZJ2MpLGqmrE9vRnKLzCodHg84Zy7GT0cCiA3EDhOY/V9mymlrG1RA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5vzGIqD50ASr9+sQYVO/q1oMmNTDO3D1SknWbu2Fq+0mzqGt/ /47BqUXTqq41wLWoLhidLrh5dZhy7y009XSzD915uA+C8WDLnjR7hGM/BMTioGjTBNjw3Is/sVu A8oQvH3yn5oqAK+eS82OqIbmLKxcZBCv/4lVjtifU5P+mM1opSFYrZSwPqmqrXyvIG3c= X-Gm-Gg: AZuq6aI3EeRSg8d4/Cja4CNKe0chUmjdCC3+tdwR32lrlF5x2kOyJzqjf39Nrvwl+4t lx23ZR30UoBBepjGCqYNnVuuwD1kK+rYS4ZCm5YC82WDtKuP0JtWhqySjTTjDHNQ14j/1mV5tKo 2X1pVdVH+/UsNZM9/TtSCo56iAjQraUajsCEKuuAolXjxnv7sQ+z9lcvzqaVwO8T+FkCpVmXh/C wUksu9vs/6zro++oNnxVY0RzLzjZURCCSSv5iEacosW5zL+qEfrKlauizcOwqnBtKw/O67pHWnn kkKsjLuVC+/bzEui/2x6YixV12TGKL9BwWEdy/HX4iOIMcxPbUQV7kUg99x4cYH5bgnU42crSFy D7UJgbTolo8z5yEC0X8inlg+APLLLlGy8l3iclaP4a7T3GXv2jKRgB9N5Z1q0GH8SZZo= X-Received: by 2002:a05:620a:4086:b0:8c0:c999:df5a with SMTP id af79cd13be357-8c9eb2fa331mr1079659885a.6.1770027149608; Mon, 02 Feb 2026 02:12:29 -0800 (PST) X-Received: by 2002:a05:620a:4086:b0:8c0:c999:df5a with SMTP id af79cd13be357-8c9eb2fa331mr1079657285a.6.1770027149193; Mon, 02 Feb 2026 02:12:29 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8e0901c150sm528620466b.69.2026.02.02.02.12.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Feb 2026 02:12:28 -0800 (PST) Message-ID: <472d7db3-db34-4966-aa17-588e1153ba12@oss.qualcomm.com> Date: Mon, 2 Feb 2026 11:12:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] Input: aw86938 - add driver for Awinic AW86938 To: Dmitry Torokhov , Griffin Kroah-Hartman Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Luca Weiss , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260128-aw86938-driver-v2-0-b51ee086aaf5@fairphone.com> <20260128-aw86938-driver-v2-2-b51ee086aaf5@fairphone.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: ytlARisu2uT5Zt72DS7jTsndqrdKG97y X-Authority-Analysis: v=2.4 cv=FNYWBuos c=1 sm=1 tr=0 ts=6980788e cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Tsre1VS37Hk-rMnNNKQA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA4NSBTYWx0ZWRfX9fIQk2gq+MA/ qfU18f0A78BeDquD7+5fjmxId2k5Mcd8HNwz/BxUBETDrPW5ZgsMxXpNdFI4UuK2/yxZnQXJOK/ vyxsDgLVq+1bNIqbVsN7wYx0XicUFSTuVHXzzx2jNONV9zJ5WcrEQ53w3KMNCZ+Mx9v06nSYiy3 qeWOkID98W04oDrA5YcKJ5c35w6qXGJVlgAj+Ef0AbKfo1em1C++a3xL//DgqARJMxTfmpPCJs0 ioLnKmp6KMvS9jpjFgG5eB5Zdy9EiIwwlCMRjDwxByGM6VUOKc02ypuI3kSmiab9fZqkA/iJ2x1 zkB4odf9YfxRqVHu1P1RSJG7/lhCINhrwRpgEbfTTgpFhJ/Zbf+7ksPocHWRhPyP9q0JrXD+VsJ BSOiwVE3ex0RQ0QSY3V6J+eHbJaz5mFYyNTEj+eHgwJHBavnWxb1HBon1v1IS+utzYkxMKeGseB z2F68oXQrLAa0UB1KbA== X-Proofpoint-GUID: ytlARisu2uT5Zt72DS7jTsndqrdKG97y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_03,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 clxscore=1015 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020085 On 2/1/26 2:49 AM, Dmitry Torokhov wrote: > Hi Griffin, > > On Wed, Jan 28, 2026 at 04:51:14PM +0100, Griffin Kroah-Hartman wrote: >> @@ -717,9 +746,19 @@ static int aw86927_detect(struct aw86927_data *haptics) >> >> chip_id = be16_to_cpu(read_buf); >> >> - if (chip_id != AW86927_CHIPID) { >> - dev_err(haptics->dev, "Unexpected CHIPID value 0x%x\n", chip_id); >> - return -ENODEV; >> + switch (haptics->model) { >> + case AW86927: >> + if (chip_id != AW86927_CHIPID) { >> + dev_err(haptics->dev, "Unexpected CHIPID value 0x%x\n", chip_id); >> + return -ENODEV; >> + } > > If we are able to query chip ID why do we need to have separate > compatibles? I would define chip data structure with differences between > variants and assign and use it instead of having separate compatible. dt-bindings guidelines explicitly call for this, a chipid comparison then works as a safety net Konrad