From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4680C433F5 for ; Mon, 13 Sep 2021 16:49:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3BF060F36 for ; Mon, 13 Sep 2021 16:49:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239408AbhIMQvK (ORCPT ); Mon, 13 Sep 2021 12:51:10 -0400 Received: from relayfre-01.paragon-software.com ([176.12.100.13]:54208 "EHLO relayfre-01.paragon-software.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238219AbhIMQvJ (ORCPT ); Mon, 13 Sep 2021 12:51:09 -0400 Received: from dlg2.mail.paragon-software.com (vdlg-exch-02.paragon-software.com [172.30.1.105]) by relayfre-01.paragon-software.com (Postfix) with ESMTPS id 53B381D40; Mon, 13 Sep 2021 19:49:52 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paragon-software.com; s=mail; t=1631551792; bh=QZCRnWQdSHor/Ryg4X8KggMjh3St8DKV+rc3R8trBA4=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=WqfsCsTqMjbyHD8t0J8VAvE9do5+UH2ejGWlKYi9q03mf70M5QRP9s123m/aA2dAO UN/E983ZwBmfxYE9VQw6SlvS1yQ3BXv7VjrjERpShXtpYVLRLextEveYeLKlcmxZ3O tQUG7SLzPK+x3bPj8Wd4qTkS05Coqo09XExv2RUM= Received: from [192.168.211.103] (192.168.211.103) by vdlg-exch-02.paragon-software.com (172.30.1.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 13 Sep 2021 19:49:51 +0300 Message-ID: <472ecb1c-578d-137a-9ec1-182642dac037@paragon-software.com> Date: Mon, 13 Sep 2021 19:49:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH][next] fs/ntfs3: Remove redundant initialization of variable err Content-Language: en-US To: Colin King , CC: , References: <20210903132458.14342-1-colin.king@canonical.com> From: Konstantin Komarov In-Reply-To: <20210903132458.14342-1-colin.king@canonical.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.211.103] X-ClientProxiedBy: vobn-exch-01.paragon-software.com (172.30.72.13) To vdlg-exch-02.paragon-software.com (172.30.1.105) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.09.2021 16:24, Colin King wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is never read, it > is being updated later on. The assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > fs/ntfs3/index.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c > index 0daca9adc54c..b1175542d854 100644 > --- a/fs/ntfs3/index.c > +++ b/fs/ntfs3/index.c > @@ -1401,7 +1401,7 @@ int indx_find_raw(struct ntfs_index *indx, struct ntfs_inode *ni, > static int indx_create_allocate(struct ntfs_index *indx, struct ntfs_inode *ni, > CLST *vbn) > { > - int err = -ENOMEM; > + int err; > struct ntfs_sb_info *sbi = ni->mi.sbi; > struct ATTRIB *bitmap; > struct ATTRIB *alloc; > Hi Colin, thanks for the patch - applied it. Best regards.