From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758AbdHPMJ0 (ORCPT ); Wed, 16 Aug 2017 08:09:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:42129 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752467AbdHPMJY (ORCPT ); Wed, 16 Aug 2017 08:09:24 -0400 Subject: Re: [PATCH 3/5] reset: Add Realtek RTD1295 driver To: Philipp Zabel , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Roc He , =?UTF-8?B?6JKL5Li955C0?= References: <20170816003847.6208-1-afaerber@suse.de> <20170816003847.6208-4-afaerber@suse.de> <1502876699.7596.3.camel@pengutronix.de> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <47359100-edf7-5aa4-a3ee-1250c8a84c5e@suse.de> Date: Wed, 16 Aug 2017 14:09:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502876699.7596.3.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp, Am 16.08.2017 um 11:44 schrieb Philipp Zabel: > On Wed, 2017-08-16 at 02:38 +0200, Andreas Färber wrote: >> Add a per-register reset controller driver. This deals with the fact >> that not all registers are adjoined. > > the way you handle the non-contiguous reset registers, this looks like > a candidate to join the recently discussed reset-simple driver [1]. > Could you check if that would fit? Thanks, I appreciate the idea, and it looks like you already have the active-low logic in place. Are you okay with keeping the first three as separate nodes, or would you rather want one node to cover the first three registers, plus two separate ones for the non-contiguous cases? Or is the simple driver supposed to cover gaps, too? Then we could go with just two nodes. (I found it weird to have reset and then reset4, so I went with separate ones as seen downstream.) Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)