mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>,
	kgdb-bugreport@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdb: kdb_main: refactor code in kdb_md_line
Date: Thu, 16 Aug 2018 08:47:07 -0500	[thread overview]
Message-ID: <47366683-621e-6efa-91d5-69ac93a9af37@embeddedor.com> (raw)
In-Reply-To: <20180816093251.jc5tvmzqrpgtyqms@holly.lan>



On 8/16/18 4:32 AM, Daniel Thompson wrote:

>> diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c
>> index 2ddfce8..4b896a6 100644
>> --- a/kernel/debug/kdb/kdb_main.c
>> +++ b/kernel/debug/kdb/kdb_main.c
>> @@ -1538,25 +1538,9 @@ static void kdb_md_line(const char *fmtstr, unsigned long addr,
>>  			wc.word = word;
>>  #define printable_char(c) \
>>  	({unsigned char __c = c; isascii(__c) && isprint(__c) ? __c : '.'; })
>> -			switch (bytesperword) {
>> -			case 8:
>> +			for (i = 0; i < bytesperword; i++)
> 
> i already a control variable for the outer loop. It is not safe to reuse
> it here.
> 

Oh I see. I'll send v2 shortly.

Thanks
--
Gustavo

      reply	other threads:[~2018-08-16 13:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15 15:06 Gustavo A. R. Silva
2018-08-16  9:32 ` Daniel Thompson
2018-08-16 13:47   ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47366683-621e-6efa-91d5-69ac93a9af37@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=daniel.thompson@linaro.org \
    --cc=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®