From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Sabau, Radu bogdan" <Radu.Sabau@analog.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: adp1050: add bindings
Date: Wed, 20 Mar 2024 15:19:35 +0100 [thread overview]
Message-ID: <473a833c-b166-4002-823c-a71e5aaa784a@linaro.org> (raw)
In-Reply-To: <SA1PR03MB6499527C7BEE83A3E4EE6AFBF7332@SA1PR03MB6499.namprd03.prod.outlook.com>
On 20/03/2024 14:05, Sabau, Radu bogdan wrote:
>> +examples:
>> + - |
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + clock-frequency = <100000>;
>> +
>> + hwmon@70 {
>> + compatible = "adi,adp1050";
>> + reg = <0x70>;
>> + vcc-supply = <&vcc>;
>> + };
>> + };
>> +...
>
> Results of bindings testing :
>
Yeah... please do not send patches which contain knowingly wrong code.
Code is wrong if you perform testing and result is some sort of FAILURE,
build error, warning message, static checker/linter warning message or
error.
If something is not clear, ask via email or IRC, but sending code which
does not work could cause wasted reviewer's effort.
About your warning, please start your bindings from example-schema or
latest reviewed bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-20 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 12:57 Radu Sabau
2024-03-20 12:57 ` [PATCH v3 2/2] hwmon: pmbus: adp1050: Add driver support Radu Sabau
2024-03-20 13:05 ` [PATCH v3 1/2] dt-bindings: hwmon: pmbus: adp1050: add bindings Sabau, Radu bogdan
2024-03-20 14:19 ` Krzysztof Kozlowski [this message]
2024-03-21 14:00 ` Rob Herring
2024-03-21 14:17 ` Sabau, Radu bogdan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473a833c-b166-4002-823c-a71e5aaa784a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Delphine_CC_Chiu@Wiwynn.com \
--cc=Radu.Sabau@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®