From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E401BC433E5 for ; Wed, 15 Jul 2020 15:40:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9F5C207E8 for ; Wed, 15 Jul 2020 15:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726936AbgGOPkK (ORCPT ); Wed, 15 Jul 2020 11:40:10 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:34576 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbgGOPkK (ORCPT ); Wed, 15 Jul 2020 11:40:10 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 70DBD2A1F5B Subject: Re: [PATCH v2 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart" To: Bhanu Prakash Maiya , linux-arm-kernel@lists.infradead.org Cc: Lee Jones , Furquan Shaikh , Raul E Rangel , Eric Peers , Duncan Laurie , Benson Leung , Guenter Roeck , Mauro Carvalho Chehab , "David S . Miller" , Rob Herring , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.Kernel.org, Bhanu Prakash Maiya References: <20200715082526.1760426-1-bhanumaiya@google.com> <20200715082526.1760426-2-bhanumaiya@google.com> From: Enric Balletbo i Serra Message-ID: <473adfb3-c66b-aa5a-ce61-af335002b752@collabora.com> Date: Wed, 15 Jul 2020 17:40:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200715082526.1760426-2-bhanumaiya@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi bhanu, Thank you for your patch. This patch has some style problems, please make sure to fix and resent the patch. On 15/7/20 10:25, Bhanu Prakash Maiya wrote: > From: Bhanu Prakash Maiya > > Add DT compatible string in > Documentation/devicetree/bindings/mfd/cros_ec.txt > That's actually removed you should base your changes on top of https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/?h=for-mfd-next&id=46b5780688c0d825b6b8d49b267b13102bea512d > Series-to: LKML > Series-cc: Raul E Rangel , Furquan Shaikh , Duncan Laurie , Eric Peers , Benson Leung , Enric Balletbo i Serra , Guenter Roeck , linux-kernel@vger.kernel.org, Lee Jones , Rob Herring , devicetree@vger.kernel.org > I think you need to fix your patman workflow. This should be removed from here. > Signed-off-by: Bhanu Prakash Maiya > Change-Id: Icfeab15fa04daaffc61280faf5a75cd9b23ee822 The Change-Id is useless upstream, please remove it. > Signed-off-by: Bhanu Prakash Maiya Only one signed-off per person please. > --- > Documentation/devicetree/bindings/mfd/cros-ec.txt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/cros-ec.txt b/Documentation/devicetree/bindings/mfd/cros-ec.txt > index 4860eabd0f729..ec8c5d7ecc266 100644 > --- a/Documentation/devicetree/bindings/mfd/cros-ec.txt > +++ b/Documentation/devicetree/bindings/mfd/cros-ec.txt > @@ -3,7 +3,7 @@ ChromeOS Embedded Controller > Google's ChromeOS EC is a Cortex-M device which talks to the AP and > implements various function such as keyboard and battery charging. > > -The EC can be connect through various means (I2C, SPI, LPC, RPMSG) and the > +The EC can be connect through various means (I2C, SPI, UART, LPC, RPMSG) and the > compatible string used depends on the interface. Each connection method has > its own driver which connects to the top level interface-agnostic EC driver. > Other Linux driver (such as cros-ec-keyb for the matrix keyboard) connect to > @@ -17,6 +17,10 @@ Required properties (SPI): > - compatible: "google,cros-ec-spi" > - reg: SPI chip select > > +Required properties (UART): > +- compatible: "google,cros-ec-uart" > +- reg: UART baudrate, flowcontrol > + That's odd, a reg that is mean to contain the baudrate and the flowcontrol? How? > Required properties (RPMSG): > - compatible: "google,cros-ec-rpmsg" > > @@ -72,5 +76,6 @@ spi@131b0000 { > }; > }; > > - > Example for LPC is not supplied as it is not yet implemented. > + > +Example for UART is not supplied as it is not yet implemented. >