From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751303AbdBWOMp (ORCPT ); Thu, 23 Feb 2017 09:12:45 -0500 Received: from mx2.suse.de ([195.135.220.15]:48618 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbdBWOMi (ORCPT ); Thu, 23 Feb 2017 09:12:38 -0500 Subject: Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64 To: Mark Brown References: <20170222022929.10540-1-afaerber@suse.de> <20170222022929.10540-5-afaerber@suse.de> <20170222184734.wmkbzfsz4yklofcg@sirena.org.uk> Cc: linux-arm-kernel@lists.infradead.org, Eric Miao , Haojian Zhuang , info@andromedabox.org, linux-kernel@vger.kernel.org, Daniel Mack , Robert Jarzmik , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: <473e4976-77eb-4b67-e874-ae6bd717ddaa@suse.de> Date: Thu, 23 Feb 2017 15:11:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170222184734.wmkbzfsz4yklofcg@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 22.02.2017 um 19:47 schrieb Mark Brown: > On Wed, Feb 22, 2017 at 03:29:24AM +0100, Andreas Färber wrote: > > This is patch 4 of 8, what's going on with dependencies here? No dependencies on previous patches. 5/8 adds ARCH_MMP to arm64. It compiled without this (just Kconfig warnings), so this could go through the appropriate sound tree as a cleanup. > Please use subject lines matching the style for the subsystem. This > makes it easier for people to identify relevant patches. Should I make it "ASoC: pxa: ..." then? SND_MMP_SOC selects SND_ARM, which in sound/arm/Kconfig says 'Drivers that are implemented on ASoC can be found in "ALSA for SoC audio support" section.', which confused me about whether or not this is an ASoC compliant driver if it selects a non-ASoC symbol. >> config SND_MMP_SOC >> - bool "Soc Audio for Marvell MMP chips" >> - depends on ARCH_MMP >> + bool "SoC Audio for Marvell MMP chips" >> + depends on ARCH_MMP && ARM > > There are no obvious build time architecture dependencies for this > driver, shouldn't we have an || COMPILE_TEST in here? I'm the wrong person to answer that - the symbol relies on architecture-specific SND_ARM, and my understanding was that the code still relies on platform data, therefore it did not seem worthwhile to just disable inapplicable dependencies such as MMP_SRAM (arch/arm/mach-mmp/; superseded by DT mmio-sram) or SND_ARM. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)