mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mao Jinlong <quic_jinlmao@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Tingwei Zhang <quic_tingweiz@quicinc.com>,
	Yuanfang Zhang <quic_yuanfang@quicinc.com>,
	Tao Zhang <quic_taozha@quicinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: Fix the warnings from coresight bindings
Date: Fri, 24 Nov 2023 08:50:49 +0100	[thread overview]
Message-ID: <47406b19-811f-47ab-8c08-dd8c4cc5d8bd@linaro.org> (raw)
In-Reply-To: <20231124061739.2816-1-quic_jinlmao@quicinc.com>

On 24/11/2023 07:17, Mao Jinlong wrote:
> Fix all warnings in Qualcomm boards coming from Coresight bindings.

One logical thing, one patch. That applies not only to Linux kernel, but
to all software projects.

> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 26 ----------------------
>  arch/arm64/boot/dts/qcom/msm8998.dtsi | 32 +++++++++++++++++----------
>  arch/arm64/boot/dts/qcom/sdm845.dtsi  |  5 +----
>  arch/arm64/boot/dts/qcom/sm8150.dtsi  |  5 +----
>  arch/arm64/boot/dts/qcom/sm8250.dtsi  | 24 ++++----------------
>  5 files changed, 26 insertions(+), 66 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 6ba9da9e6a8b..e42c22b26adc 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -2637,24 +2637,6 @@ funnel1_out: endpoint {
>  			};
>  		};
>  
> -		funnel@3023000 {
> -			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
> -			reg = <0x3023000 0x1000>;
> -
> -			clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
> -			clock-names = "apb_pclk", "atclk";
> -
> -
> -			out-ports {
> -				port {
> -					funnel2_out: endpoint {
> -						remote-endpoint =
> -						  <&merge_funnel_in2>;
> -					};
> -				};
> -			};
> -		};

Why do you remove nodes? How is this anyhow related to commit msg?
Nothing here is explained.

> -
>  		funnel@3025000 {
>  			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
>  			reg = <0x3025000 0x1000>;
> @@ -2681,14 +2663,6 @@ merge_funnel_in1: endpoint {
>  						  <&funnel1_out>;
>  					};
>  				};
> -
> -				port@2 {
> -					reg = <2>;
> -					merge_funnel_in2: endpoint {
> -						remote-endpoint =
> -						  <&funnel2_out>;
> -					};

Why?

> -				};
>  			};
>  
>  			out-ports {
> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> index b485bf925ce6..ebc5ba1b369e 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
> @@ -2031,9 +2031,11 @@ etm5: etm@7c40000 {
>  
>  			cpu = <&CPU4>;
>  
> -			port {
> -				etm4_out: endpoint {
> -					remote-endpoint = <&apss_funnel_in4>;
> +			out-ports {
> +				port {

So you want to say out-ports is missing? Commit msg is really not
explaining anything.

> +					etm4_out: endpoint {
> +						remote-endpoint = <&apss_funnel_in4>;
> +					};
>  				};


Best regards,
Krzysztof


  reply	other threads:[~2023-11-24  7:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-24  6:17 Mao Jinlong
2023-11-24  7:50 ` Krzysztof Kozlowski [this message]
2023-11-27  4:06   ` Jinlong Mao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47406b19-811f-47ab-8c08-dd8c4cc5d8bd@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_jinlmao@quicinc.com \
    --cc=quic_taozha@quicinc.com \
    --cc=quic_tingweiz@quicinc.com \
    --cc=quic_yuanfang@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®