From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fllvem-ot03.ext.ti.com (fllvem-ot03.ext.ti.com [198.47.19.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 476D81F4620; Wed, 19 Feb 2025 16:30:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.245 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739982659; cv=none; b=kj6Lt+C3ZNTlbZZFFdqpSeeRnqWb0m/d6aHqMHvnCn4z87tOo+4Up6cfS8GwZgvgDj9PGRiHunnAzFR7Ey6ARXsz4gmwtNUAgCo4+flZl2f8SW6ba3fwfVYOZST2FyUwiCsiXKgIuiNAZdf4Gtatkja6X06jDmGUASi3UUFPSvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739982659; c=relaxed/simple; bh=EphWe4XnDZVznPNpyV60sRqV6Sh9Q/MW56Hpk/4y+Og=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=kGYXOKuXkbpbmisFVunuMaE61c5Dyl2Ppn/svHzTYo9GaJtG6FzfpTYLQq4qzBEdvme6ByDf1NrKfGDbELJEVrbdg4+78LnmYPn0koeByNmWBgnG4hEPgIdYdXGpl89cPQrLhT5kZLfqrWOHIVeaV7+SLuGMkvXmnis8jCZ/Bqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=J/qcVos0; arc=none smtp.client-ip=198.47.19.245 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="J/qcVos0" Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllvem-ot03.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 51JGUfWb1867086 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 19 Feb 2025 10:30:41 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1739982641; bh=2egRYoPiMWdseZC/79NM1RVQlrpuaV4udcoVD6JgBok=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=J/qcVos0abyVyF//MGI0x0i72YiUfOINqzCCL1BAxTHss8zWQNIw0vcml99p2yT5K 7j2Eo871/norErExgvjGnnWc1vXK/2PHB1pKitnzeXsi3oct3gZOF4QPvv1zjkiXp+ 6EsOrKNVRoRTt0p0wDsTUeSkD5lQnXQJnnBbcNF0= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTP id 51JGUf8d094252; Wed, 19 Feb 2025 10:30:41 -0600 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 19 Feb 2025 10:30:41 -0600 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 19 Feb 2025 10:30:40 -0600 Received: from [172.24.227.151] (uda0510294.dhcp.ti.com [172.24.227.151]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 51JGUbN9123245; Wed, 19 Feb 2025 10:30:38 -0600 Message-ID: <4740c3f8-5051-4e25-af91-b45735ffef31@ti.com> Date: Wed, 19 Feb 2025 22:00:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/10] arm64: dts: ti: k3-am62-wakeup: Add wakeup R5F node To: Judith Mendez , Nishanth Menon , Vignesh Raghavendra CC: Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Andrew Davis , Hari Nagalla References: <20250210221530.1234009-1-jm@ti.com> <20250210221530.1234009-2-jm@ti.com> Content-Language: en-US From: Beleswar Prasad Padhi In-Reply-To: <20250210221530.1234009-2-jm@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Hi Judith, On 11/02/25 03:45, Judith Mendez wrote: > From: Hari Nagalla > > AM62 SoC devices have a single core R5F processor in wakeup domain. > The R5F processor in wakeup domain is used as a device manager > for the SoC. > > Signed-off-by: Devarsh Thakkar > Signed-off-by: Hari Nagalla > Signed-off-by: Judith Mendez > --- > Changes since v4: > - No change > --- > arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi | 25 ++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > index 9b8a1f85aa15c..061819a64300f 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62-wakeup.dtsi > @@ -106,6 +106,31 @@ wkup_rti0: watchdog@2b000000 { > status = "reserved"; > }; > > + wkup_r5fss0: r5fss@78000000 { > + compatible = "ti,am62-r5fss"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x78000000 0x00 0x78000000 0x8000>, > + <0x78100000 0x00 0x78100000 0x8000>; > + power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>; > + status = "disabled"; > + > + wkup_r5fss0_core0: r5f@78000000 { > + compatible = "ti,am62-r5f"; > + reg = <0x78000000 0x00008000>, > + <0x78100000 0x00008000>; > + reg-names = "atcm", "btcm"; > + ti,sci = <&dmsc>; > + ti,sci-dev-id = <121>; > + ti,sci-proc-ids = <0x01 0xff>; > + resets = <&k3_reset 121 1>; > + firmware-name = "am62-wkup-r5f0_0-fw"; Here and everywhere else, 'resets' and 'firmware-name' are standard DT properties and should come before vendor specific properties. https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node Thanks, Beleswar > + ti,atcm-enable = <1>; > + ti,btcm-enable = <1>; > + ti,loczrama = <1>; > + }; > + }; > + > wkup_vtm0: temperature-sensor@b00000 { > compatible = "ti,j7200-vtm"; > reg = <0x00 0xb00000 0x00 0x400>,