From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbdBGKTV (ORCPT ); Tue, 7 Feb 2017 05:19:21 -0500 Received: from mx2.suse.de ([195.135.220.15]:53198 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752437AbdBGKTN (ORCPT ); Tue, 7 Feb 2017 05:19:13 -0500 Subject: Re: [PATCH v3 5/9] xen/pvh: Make sure we don't use ACPI_IRQ_MODEL_PIC for SCI To: Boris Ostrovsky References: <1486400425-5356-1-git-send-email-boris.ostrovsky@oracle.com> <1486400425-5356-6-git-send-email-boris.ostrovsky@oracle.com> Cc: roger.pau@citrix.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Juergen Gross Message-ID: <47448d12-2457-d990-21fd-3b7ccf27a4c0@suse.com> Date: Tue, 7 Feb 2017 11:19:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1486400425-5356-6-git-send-email-boris.ostrovsky@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/17 18:00, Boris Ostrovsky wrote: > Since we are not using PIC and (at least currently) don't have IOAPIC > we want to make sure that acpi_irq_model doesn't stay set to > ACPI_IRQ_MODEL_PIC (which is the default value). If we allowed it to > stay then acpi_os_install_interrupt_handler() would try (and fail) to > request_irq() for PIC. > > Instead we set the model to ACPI_IRQ_MODEL_PLATFORM which will prevent > this from happening. > > Signed-off-by: Boris Ostrovsky Reviewed-by: Juergen Gross Juergen