From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163147AbcG0XET (ORCPT ); Wed, 27 Jul 2016 19:04:19 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:63716 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1161061AbcG0XED (ORCPT ); Wed, 27 Jul 2016 19:04:03 -0400 From: "Rafael J. Wysocki" To: Andrew Cooper Cc: Linus Torvalds , David Vrabel , Shannon Zhao , "Rafael J. Wysocki" , xen-devel , "linux-kernel@vger.kernel.org" Subject: Re: [Xen-devel] [GIT PULL] xen: features and fixes for 4.8-rc0 Date: Thu, 28 Jul 2016 01:09:06 +0200 Message-ID: <4745197.6nnjR21Chc@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <5798BB14.9090606@cantab.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 27, 2016 07:57:34 PM Andrew Cooper wrote: > On 27/07/16 19:42, Linus Torvalds wrote: > > On Wed, Jul 27, 2016 at 6:45 AM, David Vrabel wrote: > >> Shannon Zhao (16): > >> Xen: ACPI: Hide UART used by Xen > > So this caused a trivial conflict. No biggie, it wasn't bad and the > > patch was acked by Rafael. However, looking at it made me somewhat > > unhappy. > > > > Should the device entry in ACPI really be hidden unconditionally? In > > particular, if we are *not* running under virtualization, it sounds > > wrong to hide it. > > > > Comments? Am I missing something? > > The purpose of the ACPI STAO table (Status Override table, ratified in > ACPI 6.0) is to list items elsewhere in the ACPI namespace which should > be completely ignored. It is used in cases where it is impossible or > prohibitive to edit the system AML. > > The patch itself only hides the UART if instructed to do so by the STAO > table (last hunk). Right. The STAO definition document: http://wiki.xenproject.org/mediawiki/images/0/02/Status-override-table.pdf requires as to "operate as if that device does not exist", quite literally. Thanks, Rafael