From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 423E82F8EB3 for ; Mon, 1 Jun 2026 16:27:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780331269; cv=none; b=Z8IkIgKcwPPpxKh56YBI7GzvTr/V6uA4ZAJes+Dxls0UPg+SNoDg1BSxi3g9S0CweGIU+QPox4l5ysMWOqDgnAx4kEgFfo4uh5GZ8+3Xv+D/NKs9+agcibGL7BOPctG+z7zh64EPeOILseV0BlF9aXLUHdaC8WtZFLcj3nqeFEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780331269; c=relaxed/simple; bh=hJ83ANAMGKlfACSoWSYsWcwjPLWYlAw2gamYdgHqgfs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TacnQhWK1S1X6/321cIN1g2KCf4Ki7AbN5WgU3ixZwwzdNLv4XfebRB0MpJK8lr+3JlhTQpTdxzzfo/kHYVD4t1nQQnNtIkhib1X5ibH7Qzbes81dMMwNMLv47K/CK35DlGnrjssWYJYvFTbiEC46+Jm0rUkZTYN5jTCHhCU3N4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=WMJEz07D; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="WMJEz07D" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 724B4176A; Mon, 1 Jun 2026 09:27:39 -0700 (PDT) Received: from [10.163.164.232] (unknown [10.163.164.232]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B684B3F632; Mon, 1 Jun 2026 09:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1780331264; bh=hJ83ANAMGKlfACSoWSYsWcwjPLWYlAw2gamYdgHqgfs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WMJEz07DJwD3lk5ISTRXSnfMF3sfA6pRzeWlr08F8XagPv97GNAxD2MAZl9OMNuRP BoT0SrgsqTTl3dWYe+5pf0unJowIew6wmKXwrQ85HegAba5PAZQGjiSzb6KPgmSicy FpnW7AIuja72LAxgvYaGRprOX1soQsCY6soI0LAY= Message-ID: <474a4ee5-a29b-4b8d-95c4-daaf7bf5aaf6@arm.com> Date: Mon, 1 Jun 2026 21:57:36 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-hotfixes] mm/huge_memory: use correct flags for device private PMD entry To: Lorenzo Stoakes Cc: Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , SeongJae Park , Balbir Singh , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260601083044.57132-1-ljs@kernel.org> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01/06/26 9:31 pm, Lorenzo Stoakes wrote: > On Mon, Jun 01, 2026 at 09:20:51PM +0530, Dev Jain wrote: >> Sashiko continues to find existing problems :) What do you think: >> >> https://sashiko.dev/#/patchset/20260601083044.57132-1-ljs%40kernel.org > > Thanks for highlighting Dev and to be clear I'm not yelling at you :P I'm > yelling about this aspect of sashiko... :) > > So, this patch fixes a serious issue that renders THP device-private > completely broken in a way that can lead to memory corruption, and this > review comment has nothing to do with that :) > > So TL;DR - maybe as a follow up? > > IMO there's _no_ obligation to respond to stuff like this, in the same > way as somebody in a review saying 'hey here's this unrelated broken > thing'. > > And this kind of thing should _never_ _ever_ block a series or patch. Yep I agree. Thanks David for bringing up the link. > > (I kinda wish sashiko didn't do it, I have extremely limited time as it is, > it'd be better as a passive background scan of existing issues or > something.) > > Cheers, Lorenzo