From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753860AbcHRCxw (ORCPT ); Wed, 17 Aug 2016 22:53:52 -0400 Received: from regular1.263xmail.com ([211.150.99.141]:49637 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753618AbcHRCxu (ORCPT ); Wed, 17 Aug 2016 22:53:50 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: daniel.meng@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: <991df5a49f5fb9e8d3405deb817ffa0d> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v9 4/4] arm64: dts: rockchip: configure usb2-phy support for rk3399-evb To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1469170846-15617-1-git-send-email-frank.wang@rock-chips.com> <1469170846-15617-5-git-send-email-frank.wang@rock-chips.com> <2024472.51n7WpJreO@diego> Cc: dianders@chromium.org, linux@roeck-us.net, groeck@chromium.org, jwerner@chromium.org, kishon@ti.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, xzy.xu@rock-chips.com, kever.yang@rock-chips.com, huangtao@rock-chips.com, william.wu@rock-chips.com, daniel.meng@rock-chips.com From: Frank Wang Message-ID: <4752a1d7-9db9-bfe9-1544-f90f33d4f560@rock-chips.com> Date: Thu, 18 Aug 2016 10:53:22 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <2024472.51n7WpJreO@diego> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/8/17 18:02, Heiko Stübner wrote: > Am Freitag, 22. Juli 2016, 15:00:46 schrieb Frank Wang: >> Add vcc5v0_host regulator for usb2-phy and enable host-port support. >> >> Signed-off-by: Frank Wang > applied to ny dts64 branch [0] with some changes: > > - the pin is named vcc5v0_host_en not host_vbus_drv in the schematics > please always try to use the names from the schematics > - separated the enablement of the subnodes > Thanks for your valuable comments, I will try to improve the quality of my patches in future. BR. Frank > Heiko > > [0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=1d3bc1d6c9c4658d554bcf89a71b35a6783a5b4e > > >> --- >> arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 44 >> +++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts >> b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts index 1a3eb14..56aeedb 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-evb.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-evb.dts >> @@ -69,6 +69,25 @@ >> regulator-max-microvolt = <3300000>; >> }; >> >> + vcc5v0_sys: vcc5v0-sys { >> + compatible = "regulator-fixed"; >> + regulator-name = "vcc5v0_sys"; >> + regulator-always-on; >> + regulator-boot-on; >> + regulator-min-microvolt = <5000000>; >> + regulator-max-microvolt = <5000000>; >> + }; >> + >> + vcc5v0_host: vcc5v0-host-regulator { >> + compatible = "regulator-fixed"; >> + enable-active-high; >> + gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&host_vbus_drv>; >> + regulator-name = "vcc5v0_host"; >> + vin-supply = <&vcc5v0_sys>; >> + }; >> + >> vcc_phy: vcc-phy-regulator { >> compatible = "regulator-fixed"; >> regulator-name = "vcc_phy"; >> @@ -89,6 +108,24 @@ >> status = "okay"; >> }; >> >> +&u2phy0 { >> + status = "okay"; >> + >> + u2phy0_host: host-port { >> + phy-supply = <&vcc5v0_host>; >> + status = "okay"; >> + }; >> +}; >> + >> +&u2phy1 { >> + status = "okay"; >> + >> + u2phy1_host: host-port { >> + phy-supply = <&vcc5v0_host>; >> + status = "okay"; >> + }; >> +}; >> + >> &uart2 { >> status = "okay"; >> }; >> @@ -121,4 +158,11 @@ >> <1 18 RK_FUNC_GPIO &pcfg_pull_down>; >> }; >> }; >> + >> + usb2 { >> + host_vbus_drv: host-vbus-drv { >> + rockchip,pins = >> + <4 25 RK_FUNC_GPIO &pcfg_pull_none>; >> + }; >> + }; >> };