From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Mathieu Malaterre <malat@debian.org>,
David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/assoc_array: annotate implicit fall through
Date: Mon, 14 Jan 2019 15:08:46 -0600 [thread overview]
Message-ID: <475381f8-3fdf-5b5e-da34-23d57ae757e7@embeddedor.com> (raw)
In-Reply-To: <20190114202454.14551-1-malat@debian.org>
On 1/14/19 2:24 PM, Mathieu Malaterre wrote:
> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
> lib/assoc_array.c:1110:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Acked-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> lib/assoc_array.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/assoc_array.c b/lib/assoc_array.c
> index c6659cb37033..0b61d3b77e5c 100644
> --- a/lib/assoc_array.c
> +++ b/lib/assoc_array.c
> @@ -1115,6 +1115,7 @@ struct assoc_array_edit *assoc_array_delete(struct assoc_array *array,
> index_key))
> goto found_leaf;
> }
> + /* fall through */
> case assoc_array_walk_tree_empty:
> case assoc_array_walk_found_wrong_shortcut:
> default:
>
prev parent reply other threads:[~2019-01-14 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 20:24 Mathieu Malaterre
2019-01-14 21:08 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475381f8-3fdf-5b5e-da34-23d57ae757e7@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=malat@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®