From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DCF0C433E1 for ; Sat, 25 Jul 2020 13:52:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E194920674 for ; Sat, 25 Jul 2020 13:52:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AqWuWZ01" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727116AbgGYNwj (ORCPT ); Sat, 25 Jul 2020 09:52:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726639AbgGYNwi (ORCPT ); Sat, 25 Jul 2020 09:52:38 -0400 Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65348C08C5C0 for ; Sat, 25 Jul 2020 06:52:38 -0700 (PDT) Received: by mail-ed1-x542.google.com with SMTP id c2so3100260edx.8 for ; Sat, 25 Jul 2020 06:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=ypjj5pTRTJCGG8++SxjYKdcYv0L6mq3Sd3wiJ6Jmy7Q=; b=AqWuWZ01ZIfafFnzObb2vAa1rB2DLoBdSS0ArEZ3p5K4zu9zu9IlBTcZwtgvYdqc2T 4CDIKRlioidVKO3p3jxd/KbHzeMBvOY2U6iaT1CpJk1QpDxxuV0PTgJOp8uYYVdB2im4 ajqqStEIsRMVSNDtUIASh9bPBKtXpyfUj3PFCj3+3VaejqN6DOdQOu7tTkzodx2J+bVw dPy1ZuLGlepWxQykDzVt3Xon74ilyvqvlhDwe9sqIZ/LM9PLXnfxGo/mspbHF0nhkdt7 7SXNf0okLTxf2NzgJwIH05UH6n+uX6r6KwT9S3juUMJcUXZHKHYCyTmlVQm/lCpabky/ LQdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ypjj5pTRTJCGG8++SxjYKdcYv0L6mq3Sd3wiJ6Jmy7Q=; b=hhSNA2dmpa1dERrWDKtPSApg85Gc5B43Cxvxdn29xI9GQeieUDUGF7n3oysp27Q3hD 3r7qUNbSz0A7kxz75xP7pAKoGjnQ1xcY7MKiyxlUQDwjlhBYPISQRB9YHA0HvK67VqoV qE7uWhnCKoNaBQW2knLbaN+hfnLd7iLC0C4nX5eq4EURIMCnmVzstVO2NYOEpMcUuAtN KmvEgbfbrkQIJFIeCRgNISzsJpBcLPegNdkc23sU3F9pEi3bbIq0Ktk6AHr4BlOVpYfT im+wlLan0K7v47WhX/WFZ4XEenqATAtvWbF3WmgwVhtc6DFP+znEQ9WizCzCyvUOPdbQ CcPA== X-Gm-Message-State: AOAM532WBPY8ZRlbvU9RWrzFiALcuXhZz09MTEjdN1gn4PaGoKw6S2uf OkWRHXMDVJJd0w+qqul/hVaTCd/G7g== X-Google-Smtp-Source: ABdhPJwVPbbE/10wTaNlUQ+7jgUBZiCUFb1Mn8lF5I2ve12C9A0eUah4bQzroLp5+LuSwKgsGcqfnw== X-Received: by 2002:a05:6402:2037:: with SMTP id ay23mr7361933edb.48.1595685156785; Sat, 25 Jul 2020 06:52:36 -0700 (PDT) Received: from [192.168.200.34] (ip5b436a54.dynamic.kabel-deutschland.de. [91.67.106.84]) by smtp.gmail.com with ESMTPSA id d24sm2918549eje.21.2020.07.25.06.52.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jul 2020 06:52:36 -0700 (PDT) Subject: Re: [PATCH v2 0/5] drm: rockchip: various ports for older VOPs To: Daniel Vetter Cc: Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , David Airlie , dri-devel , Linux ARM , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List References: <20200722181332.26995-1-knaerzche@gmail.com> From: Alex Bee Message-ID: <47599ce1-2a3b-87eb-c46e-8f7f79ca945e@gmail.com> Date: Sat, 25 Jul 2020 15:52:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 22.07.20 um 23:43 schrieb Daniel Vetter: > On Wed, Jul 22, 2020 at 8:13 PM Alex Bee wrote: >> Hi, >> >> this series mainly ports existining functionality to older SoCs - most >> importantly enables alpha blending for RK3036, RK3066, RK3126 and >> RK3188. >> Besides that, it also changes the window type from DRM_PLANE_TYPE_CURSOR >> to DRM_PLANE_TYPE_OVERLAY for VOPs that have only one (1) overlay window. > This doesn't make much sense, the cursor overlay is really just a hint > for legacy ioctls that this is the overlay that should be used for > cursors. Compositors should try to use such planes as full overlays > (if they don't want to use them as a cursor). So sounds like a case of > "fix your compositor". I agree here - but: If HWC windows would have been implemented in this particular driver, their max size would be 128x128 on some SoCs - so they woudn't be really suitable to create an OSD overlay at 4K, for example. I don't know, but I guess other vendors implement their HWC windows on this reduced HW resources as well. I guess that is one of the reasons, why userspace, which aims to be cross-plattfrom, avoids DRM_PLANE_TYPE_CURSOR when its looking for an usable overlay plane. (a heuristic, indeed) > For atomic there's 0 difference between a overlay or a cursor (primary > plane is still treated somewhat special in the RMFB ioctl, but again > that's for backwards compat reasons with existing uapi, not because > the primary plane is different). > > What does happen though is that this breaks cursor for legacy > userspace, which is probably not really what you want. Indeed not. Beforhand I was submiiting this, I looked arround and couldn't find anything which relies or even depends of a cursor window to be available. Even if: as per spec only one DRM_PLANE_TYPE_PRIMARY is mandatory, everything else is optional. > -Daniel > > >> Regards, >> Alex >> >> Changes in v2: >> - drop not yet upstreamed dsp_data_swap from RK3188 regs >> - rephrase most commit messages >> >> Alex Bee (5): >> drm: rockchip: add scaling for RK3036 win1 >> drm: rockchip: add missing registers for RK3188 >> drm: rockchip: add alpha support for RK3036, RK3066, RK3126 and RK3188 >> drm: rockchip: set alpha_en to 0 if it is not used >> drm: rockchip: use overlay windows as such >> >> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 + >> drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 42 ++++++++++++++++++--- >> drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 1 + >> 3 files changed, 38 insertions(+), 6 deletions(-) >> >> -- >> 2.17.1 >> > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch Best Regards