mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: <mingo@redhat.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86-64: fix .init section reference warnings
Date: Mon, 10 Dec 2007 16:03:37 +0000	[thread overview]
Message-ID: <475D7169.76E4.0078.0@novell.com> (raw)

The change in head_64.S is needed because ld -r renames .init.data to
.init.data.<number> for all but the first instance due to mismatching
section attributes.
The change in init_64.c is necessary because find_early_table_space()
is called from a __meminit function, but calls itself an __init one.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

 arch/x86/kernel/head_64.S |    2 +-
 arch/x86/mm/init_64.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.24-rc4/arch/x86/kernel/head_64.S	2007-12-10 16:11:18.000000000 +0100
+++ 2.6.24-rc4-x86_64-init-warning/arch/x86/kernel/head_64.S	2007-12-06 11:07:59.000000000 +0100
@@ -244,7 +244,7 @@ ENTRY(secondary_startup_64)
 
 	/* SMP bootup changes these two */
 #ifndef CONFIG_HOTPLUG_CPU
-	.pushsection .init.data
+	.pushsection .init.data, "aw"
 #endif
 	.align	8
 	.globl	initial_code
--- linux-2.6.24-rc4/arch/x86/mm/init_64.c	2007-12-10 16:11:19.000000000 +0100
+++ 2.6.24-rc4-x86_64-init-warning/arch/x86/mm/init_64.c	2007-12-04 16:09:33.000000000 +0100
@@ -317,7 +317,7 @@ static void __meminit phys_pud_init(pud_
 	__flush_tlb();
 } 
 
-static void __init find_early_table_space(unsigned long end)
+static noinline void __init_refok find_early_table_space(unsigned long end)
 {
 	unsigned long puds, pmds, tables, start;
 




                 reply	other threads:[~2007-12-10 16:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=475D7169.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®