From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: sm8250: describe all PCI MSI interrupts
Date: Thu, 25 Jan 2024 15:46:54 +0100 [thread overview]
Message-ID: <475b4eaf-bdf9-4f55-b6bd-4ba215e24144@linaro.org> (raw)
In-Reply-To: <CAA8EJpoEMsrEp02pLpceMx7fr-j9=xVDiUYt1SKHsF4YCmfvAQ@mail.gmail.com>
On 25/01/2024 14:25, Dmitry Baryshkov wrote:
>>> interrupt-map = <0 0 0 1 &intc 0 434 IRQ_TYPE_LEVEL_HIGH>, /* int_a */
>>> @@ -2349,8 +2357,16 @@ pcie2: pcie@1c10000 {
>>> ranges = <0x01000000 0x0 0x00000000 0x0 0x64200000 0x0 0x100000>,
>>> <0x02000000 0x0 0x64300000 0x0 0x64300000 0x0 0x3d00000>;
>>>
>>> - interrupts = <GIC_SPI 243 IRQ_TYPE_LEVEL_HIGH>;
>>> - interrupt-names = "msi";
>>> + interrupts = <GIC_SPI 243 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 261 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>;
>>> + interrupt-names = "msi0", "msi1", "msi2", "msi3",
>>> + "msi4", "msi5", "msi6", "msi7";
>>
>> This part looks a bit suspicious. All other platforms have these
>> interrupts in a continuous range.
>
> Hmm, pcie1 interrupts are also not contiguous. Okay, fine then:
>
Yeah, the other case has even two gaps.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-25 14:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 13:06 [PATCH 1/6] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
2024-01-25 13:06 ` [PATCH 2/6] arm64: dts: qcom: sm8250: " Krzysztof Kozlowski
2024-01-25 13:18 ` Dmitry Baryshkov
2024-01-25 13:25 ` Dmitry Baryshkov
2024-01-25 14:46 ` Krzysztof Kozlowski [this message]
2024-01-25 13:06 ` [PATCH 3/6] arm64: dts: qcom: sm8350: " Krzysztof Kozlowski
2024-01-25 13:20 ` Dmitry Baryshkov
2024-01-25 13:06 ` [PATCH 4/6] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
2024-01-25 13:23 ` Dmitry Baryshkov
2024-01-25 13:06 ` [PATCH 5/6] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
2024-01-25 13:26 ` Dmitry Baryshkov
2024-01-25 13:41 ` neil.armstrong
2024-01-25 13:06 ` [PATCH 6/6] arm64: dts: qcom: sm8650: " Krzysztof Kozlowski
2024-01-25 13:26 ` Dmitry Baryshkov
2024-01-25 13:43 ` neil.armstrong
2024-01-25 13:19 ` [PATCH 1/6] arm64: dts: qcom: sm8150: " Dmitry Baryshkov
2024-01-25 16:33 ` Konrad Dybcio
2024-01-26 9:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=475b4eaf-bdf9-4f55-b6bd-4ba215e24144@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®