From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC7CC001DC for ; Mon, 31 Jul 2023 12:16:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231349AbjGaMQY (ORCPT ); Mon, 31 Jul 2023 08:16:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbjGaMQW (ORCPT ); Mon, 31 Jul 2023 08:16:22 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6631B197 for ; Mon, 31 Jul 2023 05:16:21 -0700 (PDT) Received: from kwepemm600013.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RDxxn3ZpqzVjf2; Mon, 31 Jul 2023 20:14:37 +0800 (CST) Received: from [10.174.178.46] (10.174.178.46) by kwepemm600013.china.huawei.com (7.193.23.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 20:16:18 +0800 Subject: Re: [PATCH V2 5/5] mtd: Add several functions to the fail_function list To: ZhaoLong Wang , , , CC: , , References: <20230718085119.3885747-1-wangzhaolong1@huawei.com> <20230718085119.3885747-6-wangzhaolong1@huawei.com> From: Zhihao Cheng Message-ID: <475deeb5-5517-4784-a9e5-409ef16e42c4@huawei.com> Date: Mon, 31 Jul 2023 20:16:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20230718085119.3885747-6-wangzhaolong1@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600013.china.huawei.com (7.193.23.68) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2023/7/18 16:51, ZhaoLong Wang дµÀ: > add mtd_read(), mtd_write(), mtd_erase(), mtd_block_markbad() to > fail_function list for testing purpose > It could be better if you can provide some examples for how to use these error injection interfaces. > Signed-off-by: ZhaoLong Wang > --- > drivers/mtd/mtdcore.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index e00b12aa5ec9..ecf1c5e68479 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -1396,6 +1397,7 @@ int mtd_erase(struct mtd_info *mtd, struct erase_info *instr) > return ret; > } > EXPORT_SYMBOL_GPL(mtd_erase); > +ALLOW_ERROR_INJECTION(mtd_erase, ERRNO); > > /* > * This stuff for eXecute-In-Place. phys is optional and may be set to NULL. > @@ -1493,6 +1495,7 @@ int mtd_read(struct mtd_info *mtd, loff_t from, size_t len, size_t *retlen, > return ret; > } > EXPORT_SYMBOL_GPL(mtd_read); > +ALLOW_ERROR_INJECTION(mtd_read, ERRNO); > > int mtd_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen, > const u_char *buf) > @@ -1509,6 +1512,7 @@ int mtd_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen, > return ret; > } > EXPORT_SYMBOL_GPL(mtd_write); > +ALLOW_ERROR_INJECTION(mtd_write, ERRNO); > > /* > * In blackbox flight recorder like scenarios we want to make successful writes > @@ -2329,7 +2333,7 @@ int mtd_block_markbad(struct mtd_info *mtd, loff_t ofs) > return 0; > } > EXPORT_SYMBOL_GPL(mtd_block_markbad); > - > +ALLOW_ERROR_INJECTION(mtd_block_markbad, ERRNO); > /* > * default_mtd_writev - the default writev method > * @mtd: mtd device description object pointer >