From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org
Cc: Linus Torvalds <torvalds@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Borislav Petkov <bp@suse.de>,
Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH v2] docs: Add a document on how to fix a messy diffstat
Date: Wed, 30 Mar 2022 12:07:25 +0700 [thread overview]
Message-ID: <476370b7-9325-21a3-2696-d74e326bf160@gmail.com> (raw)
In-Reply-To: <87wngc6a7q.fsf@meer.lwn.net>
On 29/03/22 22.37, Jonathan Corbet wrote:
> +So what is to be done? The best response when confronted with this
> +situation is to indeed to do a merge with the branch you intend your work
> +to be pulled into, but to do it privately, as if it were the source of
> +shame. Create a new, throwaway branch and do the merge there::
> +
> + ... vM --- vN-rc1 --- vN-rc2 --- vN-rc3 --- ... --- vN-rc7 --- vN
> + | | |
> + | +-- c1 --- c2 --- ... --- cN |
> + | / | |
> + +-- x1 --- x2 --- x3 +------------+-- TEMP
> +
> +The merge operation resolves all of the complications resulting from the
> +multiple beginning points, yielding a coherent result that contains only
> +the differences from the mainline branch. Now it will be possible to
> +generate a diffstat with the desired information::
> +
> + $ git diff -C --stat --summary linus..TEMP
> +
> +Save the output from this command, then simply delete the TEMP branch;
> +definitely do not expose it to the outside world. Take the saved diffstat
> +output and edit it into the messy pull request, yielding a result that
> +shows what is really going on. That request can then be sent upstream.
Looks OK.
Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
--
An old man doll... just what I always wanted! - Clara
prev parent reply other threads:[~2022-03-30 5:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 15:37 Jonathan Corbet
2022-03-30 1:43 ` Akira Yokosawa
2022-03-30 5:07 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476370b7-9325-21a3-2696-d74e326bf160@gmail.com \
--to=bagasdotme@gmail.com \
--cc=akiyks@gmail.com \
--cc=bp@suse.de \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®