From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbaESU4e (ORCPT ); Mon, 19 May 2014 16:56:34 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:57424 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751626AbaESU4b (ORCPT ); Mon, 19 May 2014 16:56:31 -0400 From: "Rafael J. Wysocki" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, arvind.chauhan@arm.com, inderpal.s@samsung.com, pavel@ucw.cz, nm@ti.com, chander.kashyap@linaro.org, Greg Kroah-Hartman , Amit Daniel Kachhap , Kukjin Kim , Shawn Guo , Sudeep Holla Subject: Re: [PATCH Resend] driver/core: cpu: initialize opp table Date: Mon, 19 May 2014 23:13:24 +0200 Message-ID: <4765191.0FhyvSGyvF@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.15.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <60d825e8bfe01f8a5ff98fffaf51ffbf04c7d175.1400480033.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, May 19, 2014 11:59:11 AM Viresh Kumar wrote: > All drivers expecting CPU's OPPs from device tree initialize OPP table using > of_init_opp_table() and there is nothing driver specific in that. They all do it > in the same way adding to code redundancy. > > It would be better if we can get rid of code redundancy by initializing CPU OPPs > from core code for all CPUs that have a "operating-points" property defined in > their node. > > This patch initializes OPPs as soon as CPU device is registered in > register_cpu(). > > Cc: Greg Kroah-Hartman > Cc: Amit Daniel Kachhap > Cc: Kukjin Kim > Cc: Shawn Guo > Cc: Sudeep Holla > Signed-off-by: Viresh Kumar > --- > V1-V2: > A colleague spotted some extra debug prints in my first mail :( > > Replace > + pr_err("****%s: failed to init OPP table for cpu%d, err: %d\n", > with > + pr_err("%s: failed to init OPP table for cpu%d, err: %d\n", > > drivers/base/cpu.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c > index 006b1bc..74ce944 100644 > --- a/drivers/base/cpu.c > +++ b/drivers/base/cpu.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > > #include "base.h" > > @@ -349,11 +350,20 @@ int register_cpu(struct cpu *cpu, int num) > if (cpu->hotpluggable) > cpu->dev.groups = hotplugable_cpu_attr_groups; > error = device_register(&cpu->dev); > - if (!error) What about if (error) return error; and then you'd save an indentation level? Anyway, I find adding of_node* stuff directly to the driver core this way kind of disgusting as there still are platforms that don't use it. Can we have a call to a function that will change into an empty stub on such platforms here, please? > + if (!error) { > per_cpu(cpu_sys_devices, num) = &cpu->dev; > - if (!error) > register_cpu_under_node(num, cpu_to_node(num)); > > + /* Initialize CPUs OPP table */ > + if (of_node_get(cpu->dev.of_node)) { > + error = of_init_opp_table(&cpu->dev); > + if (error && error != -ENODEV) > + pr_err("%s: failed to init OPP table for cpu%d, err: %d\n", > + __func__, num, error); > + of_node_put(cpu->dev.of_node); > + } > + } > + > return error; > } > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.