From: "H. Peter Anvin" <hpa@zytor.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 4/4] x86: Final unification of local_{32|64}.h
Date: Sun, 16 Dec 2007 15:48:00 -0800 [thread overview]
Message-ID: <4765B930.8010208@zytor.com> (raw)
In-Reply-To: <1197848331.3749.86.camel@brick>
Harvey Harrison wrote:
>
> Do you have a stylistic preference between these two options:
>
> Option 1) Rely on CPP string constant concatenation
>
> // possibly include trailing space here to avoid remembering
> // leading space on the register names
> # define _ASM_INC "incl"
>
> static inline void local_inc(local_t *l)
> {
> __asm__ __volatile__(
> _ASM_INC " %0"
> :"+m" (l->a.counter));
> }
>
This is what I have used up to this point, except including the space in
the macro:
#define _ASM_INC " incl "
_ASM_INC "%0"
-hpa
next prev parent reply other threads:[~2007-12-16 23:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 12:04 Harvey Harrison
2007-12-16 15:31 ` Ingo Molnar
2007-12-16 22:48 ` H. Peter Anvin
2007-12-16 23:38 ` Harvey Harrison
2007-12-16 23:48 ` H. Peter Anvin [this message]
2007-12-16 23:59 ` Harvey Harrison
2007-12-17 0:06 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4765B930.8010208@zytor.com \
--to=hpa@zytor.com \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®