From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 212293815EF for ; Wed, 8 Jul 2026 14:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783519840; cv=none; b=kCmgGHvA51CGvRJFvzix9golVl385FDZQEOUxFcGDXda+HuebFRdGc2Wjvs5VSFHcYV+HZP4KGTSUEMl28prTF/B03MI65Nrc38/499EZz10OKo+4u31JilXvhNWWN49c6PwnEKhR8F2j10oKlJ6POZAqrkq68Prw9w+Vfvj5LA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783519840; c=relaxed/simple; bh=AFwfd7Yn4EH4PNUXJ3nn4zm9f+PLaHGLkpoj3xgsyrM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DAkI23wzdVYjcWOfRWD4SQ0oaq3AqtpO9T9jdAYhAetAF/KaaCjfL6D3kq7uHVBbAGAbtr3Mf8b4+PfRGzrQYuofrLp3ggjWKzMk7CGQm2ahV8eQWlbXq6DARaWUss3Cxm99JNitHj2P6nwHzuhBy7XwhkOJutdHxINheH/jMLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MfEDf5qs; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MfEDf5qs" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493bf73ec2aso4261325e9.2 for ; Wed, 08 Jul 2026 07:10:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783519837; x=1784124637; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=AFwfd7Yn4EH4PNUXJ3nn4zm9f+PLaHGLkpoj3xgsyrM=; b=MfEDf5qsK/0NijVV4YBYsBNGRn043imjrTNmMB/94+Z2t4f3sd6Q/gqcwVCpWKQeey jMBVJe5BGf1Ms9cbzgEX47xUvKiUeidfvzLwZCZNOPY7TLAn7iVZCKhk3rlmUlhe0RH1 EOwRmUXybblxmEKp/Mz5VuhH9/OYQWpesN2Levlpp9G9ugZ7LfPZzQEjLVLEPsLX0s1q /8omW2SppIeEjHLje/16LKely9dJxhmNbdEVJ2A584Hi9ndZOA0+ZmICqn5geZk+x/o4 n2OFyDM8DafWOWiyLe23OlMJ7O6Bj0Nnn0qnjk7ciYlDHjCIyE3A80wYHbC4hnpEFLYt phCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783519837; x=1784124637; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AFwfd7Yn4EH4PNUXJ3nn4zm9f+PLaHGLkpoj3xgsyrM=; b=Jkc4Y95Sd8Gx8BOTZxFJisSrhtrJuKYY+neFCPsqbkEL+KobkwqU/zm60S/4I/jd7D mz/cO23VEfVAsL891qfC1LWSvmj04VbI+O4nrGvV0fzP+cYvmp8bKkjQQ7Uo5gkhm6jh bTExo+Wq3G9C8G7AlDFvatRv1k3khK9xSG/qHN4/QpYZdsmg+p6kJrB1t95+ba/vz02q JzRdvpzzJqrZxqfXQi/HXWjbdDGNu8RQyRJsjQBNgLOmQsBtvBMHWQseTzv5DeaGDvwO lf/VhzeR4/3AT+LDZSiOI9HrFzTnOGMt83nOLDXHDhml21ZvR72m8WS/gjsBCtJeThwp o/OA== X-Forwarded-Encrypted: i=1; AHgh+RoM/hrPa6zJRbCBwyKgCKxSRDxYUYiaJs1jFJJSzyE13ockHEcEhxkGNVwt8Unsxwbp52pIZgCRbjncz/s=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz7cz7I42ItXjFxRAF0gaZKjqTMh5sKq0vaSHxYXzWErWihuZs 1zNLAWvQ/MZSk1UltWzcDJlh3B/V4LZbKdB4bacm2S/mrq5ScwaJ/PACdpPshYA5wPCh6g== X-Gm-Gg: AfdE7ckvJHiS0vXiG6IYD4af7aCDe7qWKeyyYpxlujG6QlD67buluQc8m9Q+cKUkYkK 3UmC0MSyJ4auxgO3yXIv18jsqywG+6+BruSD/nCcJcXmSanO3EtConMZW/Z4Ty5Cj8K+TMTkf2U IopeVfNfYFtUOTXlwOB7+ttpM5aDbojxc9NrVRSe2NFzHayPjwZTh0z1LWx6+TR3+1q1QK5jmM2 f0bNuQX5Ycm5xDekP5V1Uhmk5Au+mpMMe92f8MUO0nbxR80fwXMcBE+CqfWHOB1rT+q3BMnBfj0 UagIfUrQDE+BhOdcszBKW0ie2CXB/sz16jyexk79jniPkEd7UI5AeUPbGhrBl165votRK3Eid/z nR4oNJO5ATPDHPyeUSc6W3pcPJrFMz+eS23PPFKZuu2tbn69I3ikhDHpTKF0EhLzWJmL8RcER0L VQdegG8vatYuJdL1t6MYaW9c1jFigOK3wQNPxTTc7e1TrfIroYZpwXwhUFLEGoKx19/aJsvZymz o/v369y X-Received: by 2002:a05:600c:3e11:b0:493:df1d:7488 with SMTP id 5b1f17b1804b1-493e6904b5dmr32367975e9.16.1783519837353; Wed, 08 Jul 2026 07:10:37 -0700 (PDT) Received: from [10.128.11.240] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493e0fbb410sm145207215e9.12.2026.07.08.07.10.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 07:10:31 -0700 (PDT) Sender: Julian Braha Message-ID: <4769c44a-4345-4015-afd8-1bba2474d81e@gmail.com> Date: Wed, 8 Jul 2026 15:10:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/kconfig: Drop redundant memory hotplug dependencies To: Kaitao Cheng , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Kaitao Cheng References: <20260707090331.52971-1-kaitao.cheng@linux.dev> Content-Language: en-US From: Julian Braha In-Reply-To: <20260707090331.52971-1-kaitao.cheng@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Kaitao, On 7/7/26 10:03, Kaitao Cheng wrote: > MHP_MEMMAP_ON_MEMORY is defined inside the MEMORY_HOTPLUG block, and > MEMORY_HOTPLUG already depends on SPARSEMEM_VMEMMAP. Keep the explicit > MEMORY_HOTPLUG dependency for local readability, but drop the redundant > SPARSEMEM_VMEMMAP dependency. I love a good kconfig cleanup, but why keep both the 'if MEMORY_HOTPLUG..endif' and the 'depends on MEMORY_HOTPLUG'? The "local readability" could be achieved with a comment if keeping the 'if..endif'. And if we don't want the comment and would prefer the explicit 'depends on', then why not remove the 'if..endif'? - Julian Braha