From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752665AbdBKBcw convert rfc822-to-8bit (ORCPT ); Fri, 10 Feb 2017 20:32:52 -0500 Received: from mga09.intel.com ([134.134.136.24]:24972 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbdBKBcu (ORCPT ); Fri, 10 Feb 2017 20:32:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,143,1484035200"; d="scan'208";a="223938798" From: "Roberts, William C" To: Joe Perches , "linux-kernel@vger.kernel.org" , "apw@canonical.com" CC: "kernel-hardening@lists.openwall.com" Subject: RE: [PATCH] checkpatch: add warning on %pk instead of %pK usage Thread-Topic: [PATCH] checkpatch: add warning on %pk instead of %pK usage Thread-Index: AQHSg9UvWAPxVS9whUiJ3t5Bad2kYaFjMnOA//+bwQCAAAERAIAAjywA//9+SKCAAAx1gIAAGxWQ Date: Sat, 11 Feb 2017 01:32:39 +0000 Message-ID: <476DC76E7D1DF2438D32BFADF679FC562305DC7B@ORSMSX103.amr.corp.intel.com> References: <1486755469-21573-1-git-send-email-william.c.roberts@intel.com> <1486757549.2192.20.camel@perches.com> <476DC76E7D1DF2438D32BFADF679FC562305C559@ORSMSX103.amr.corp.intel.com> <476DC76E7D1DF2438D32BFADF679FC562305C5BA@ORSMSX103.amr.corp.intel.com> <1486766996.2192.30.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDcxMjdjNTgtYjI3NC00MDMwLWE1MzYtNjY4NmNhZjgzMTYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IitVME5UeHAwNzJFYzNNWGl2WFp5Q052ZDNPWE9LaUNLYWhaSlpOQ2FxMU09In0= x-ctpclassification: CTP_IC x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > By "normal" I'm referring to things that call into pointer(), just > > casually looking I see bstr_printf vsnprintf kvasprintf, which would > > be easy enough to add > > > > > What do you think is missing? sn?printf ? That's easy to add. > > > > The problem starts to get hairy when we think of how often folks roll > > their own logging macros (see some small sampling at the end). > > > > I think we would want to add DEBUG DBG and sn?printf and maybe > > consider dropping the \b on the regex so it's a bit more matchy but > > still shouldn't end up matching on any ASM as you pointed out in the V2 nack. > > > > Ill break this down into: > > 1. the patch as I know you'll take it, as you wrote it :-P 2. Adding > > to the logging macros 3. exploring making it less matchy -Kees and Andrew they likely don't care about the rest of this... I have been working up a regex (I suck at these) to match C functions that have an invalid %p format string and take arguments: http://www.regexr.com/3f92k This could be a way to get better coverage in a more generic approach, thoughts?