From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751250AbdJDQR6 convert rfc822-to-8bit (ORCPT ); Wed, 4 Oct 2017 12:17:58 -0400 Received: from mga07.intel.com ([134.134.136.100]:38422 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbdJDQR5 (ORCPT ); Wed, 4 Oct 2017 12:17:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,477,1500966000"; d="scan'208";a="142681236" From: "Roberts, William C" To: Greg KH , "Tobin C. Harding" CC: Petr Mladek , Joe Perches , "Ian Campbell" , Sergey Senozhatsky , "kernel-hardening@lists.openwall.com" , "linux-kernel@vger.kernel.org" , Catalin Marinas , Will Deacon , Steven Rostedt , Chris Fries , Dave Weinstein Subject: RE: [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter options Thread-Topic: [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter options Thread-Index: AQHTPO7+KFAvQMjWbk2fBUg2twrgAaLT3nvQ Date: Wed, 4 Oct 2017 16:17:54 +0000 Message-ID: <476DC76E7D1DF2438D32BFADF679FC563EAF4C9D@ORSMSX103.amr.corp.intel.com> References: <1506816410-10230-1-git-send-email-me@tobin.cc> <20171004085850.GH28247@kroah.com> In-Reply-To: <20171004085850.GH28247@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Wednesday, October 4, 2017 1:59 AM > To: Tobin C. Harding > Cc: Petr Mladek ; Joe Perches ; Ian > Campbell ; Sergey Senozhatsky > ; kernel-hardening@lists.openwall.com; linux- > kernel@vger.kernel.org; Catalin Marinas ; Will > Deacon ; Steven Rostedt ; > Roberts, William C ; Chris Fries > ; Dave Weinstein > Subject: Re: [kernel-hardening] [RFC V2 0/6] add more kernel pointer filter > options > > On Sun, Oct 01, 2017 at 11:06:44AM +1100, Tobin C. Harding wrote: > > Version 2 of Greg's patch series with changes made as suggested by comments > to V1. > > > > Applies on top of Linus' current development tree > > > > a8c964eacb21288b2dbfa9d80cee5968a3b8fb21 > > > > V1 cover letter: > > > > Here's a short patch series from Chris Fries and Dave Weinstein that > > implements some new restrictions when printing out kernel pointers, as > > well as the ability to whitelist kernel pointers where needed. > > > > These patches are based on work from William Roberts, and also are > > inspired by grsecurity's %pP to specifically whitelist a kernel > > pointer, where it is always needed, like the last patch in the series > > shows, in the UIO drivers (UIO requires that you know the address, > > it's a hardware address, nothing wrong with seeing that...) > > > > I haven't done much to this patch series, only forward porting it from > > an older kernel release (4.4) and a few minor tweaks. [snip] > > Nice! Thanks for doing this work, looks great to me. Care to resend the next > version as a "real" one (i.e. no RFC)? It looks like the only gripe from others was on the debug output change, so I'd drop that change out of the series. Otherwise, LGTM. > > thanks, > > greg k-h