From: "Arnd Bergmann" <arnd@arndb.de>
To: "Javier Martinez Canillas" <javierm@redhat.com>,
linux-kernel@vger.kernel.org
Cc: "kernel test robot" <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev,
"Andreas Larsson" <andreas@gaisler.com>,
"David S . Miller" <davem@davemloft.net>,
"Helge Deller" <deller@gmx.de>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc: Fix undefined reference to fb_is_primary_device
Date: Tue, 20 Feb 2024 09:40:50 +0100 [thread overview]
Message-ID: <476ca8e4-b0c8-4be2-ad65-8430c7f4acc9@app.fastmail.com> (raw)
In-Reply-To: <20240220003433.3316148-1-javierm@redhat.com>
On Tue, Feb 20, 2024, at 01:34, Javier Martinez Canillas wrote:
> Commit 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE
> symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only
> have fbcon/VT and DRM fbdev emulation, but without support for any legacy
> fbdev driver.
>
> Unfortunately, it missed to change a CONFIG_FB in arch/sparc/Makefile and
> that leads to the following linking error in some sparc64 configurations:
>
> sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function
> `fbcon_fb_registered':
>>> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device'
>
> Fixes: 55bffc8170bb ("fbdev: Split frame buffer support in FB and
> FB_CORE symbols")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@intel.com/
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by; Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2024-02-20 8:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 0:34 Javier Martinez Canillas
2024-02-20 8:21 ` Thomas Zimmermann
2024-02-20 8:40 ` Arnd Bergmann [this message]
2024-02-20 9:10 ` Thomas Zimmermann
2024-02-20 9:43 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476ca8e4-b0c8-4be2-ad65-8430c7f4acc9@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®