From: "Xinlei Lee (李昕磊)" <Xinlei.Lee@mediatek.com>
To: "chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"sam@ravnborg.org" <sam@ravnborg.org>,
"Jitao Shi (石记涛)" <jitao.shi@mediatek.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v2 2/3] drm/panel: boe-tv101wum-nl6: Reduce lcm_reset to send initial code time
Date: Thu, 12 Jan 2023 09:41:33 +0000 [thread overview]
Message-ID: <476d3b25346c440d31db3704f7ba79185a94d6db.camel@mediatek.com> (raw)
In-Reply-To: <3b6c19a9-66ac-a18c-cb3b-144066077bd1@collabora.com>
On Tue, 2023-01-10 at 10:20 +0100, AngeloGioacchino Del Regno wrote:
> Il 10/01/23 06:54, xinlei.lee@mediatek.com ha scritto:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Since the panel spec stipulates that the time from lcm_reset to DSI
> > to
> > send the initial code should be greater than 6ms and less than
> > 40ms,
> > so reduce the delay before sending the initial code and avoid panel
> > exceptions.
>
> Please change the commit title to describe what you're doing.
>
> drm/panel: boe-tv101wum-nl6: Remove extra delay in init commands
>
>
> ....and the commit description should also contain something like
>
> Reduce the delay after LCM reset by removing an extra delay in the
> initialization commands array. The required delay of at least 6ms
> after
> reset is guaranteed by boe_panel_prepare().
>
> Regards,
> Angelo
>
Hi Angelo:
Thanks for your suggestions and careful revisions, I will revise my
commit description.
Best Regards!
xinlei
next prev parent reply other threads:[~2023-01-12 9:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 5:54 [PATCH v2 0/3] Reduce lcm_reset to DSI LP11 send cmd time xinlei.lee
2023-01-10 5:54 ` [PATCH v2 1/3] drm/mediatek: dsi: Reduce the time of dsi from LP11 to sending cmd xinlei.lee
2023-01-27 0:12 ` Chun-Kuang Hu
2023-01-10 5:54 ` [PATCH v2 2/3] drm/panel: boe-tv101wum-nl6: Reduce lcm_reset to send initial code time xinlei.lee
2023-01-10 9:20 ` AngeloGioacchino Del Regno
2023-01-12 9:41 ` Xinlei Lee (李昕磊) [this message]
2023-01-10 5:54 ` [PATCH v2 3/3] drm/panel: boe-tv101wum-nl6: Fine tune the panel power sequence xinlei.lee
2023-01-10 9:22 ` AngeloGioacchino Del Regno
2023-01-12 10:00 ` Xinlei Lee (李昕磊)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=476d3b25346c440d31db3704f7ba79185a94d6db.camel@mediatek.com \
--to=xinlei.lee@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®