mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Ricardo Robaina" <rrobaina@redhat.com>,
	audit@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linux-Arch <linux-arch@vger.kernel.org>
Cc: "Paul Moore" <paul@paul-moore.com>,
	"Eric Paris" <eparis@redhat.com>,
	sgrubb@redhat.com
Subject: Re: [PATCH] audit: add missing syscalls to PERM class tables
Date: Wed, 10 Jun 2026 19:05:18 +0200	[thread overview]
Message-ID: <476e0a44-c6fb-4e6a-af56-a9f1d054518a@app.fastmail.com> (raw)
In-Reply-To: <20260610164719.2668906-1-rrobaina@redhat.com>

On Wed, Jun 10, 2026, at 18:47, Ricardo Robaina wrote:
> diff --git a/include/asm-generic/audit_read.h 
> b/include/asm-generic/audit_read.h
> index fb9991f53fb6..8feebc5b4c50 100644
> --- a/include/asm-generic/audit_read.h
> +++ b/include/asm-generic/audit_read.h
> @@ -18,3 +21,19 @@ __NR_fgetxattr,
>  #ifdef __NR_readlinkat
>  __NR_readlinkat,
>  #endif
> +#ifdef __NR_file_getattr
> +__NR_file_getattr,
> +#endif
> +#ifdef __NR_stat
> +__NR_stat,
> +#endif
> +#ifdef __NR_lstat
> +__NR_lstat,
> +#endif
> +#ifdef __NR_fstat
> +__NR_fstat,
> +#endif
> +#ifdef __NR_newfstatat
> +__NR_newfstatat,
> +#endif
> +__NR_statx,

There are additional variants of 'stat' that I think you need
to cover here:

scripts/syscall.tbl:79	stat64	fstatat64			sys_fstatat64
scripts/syscall.tbl:80	stat64	fstat64				sys_fstat64
arch/x86/entry/syscalls/syscall_32.tbl:18	i386	oldstat			sys_stat
arch/x86/entry/syscalls/syscall_32.tbl:28	i386	oldfstat		sys_fstat
arch/x86/entry/syscalls/syscall_32.tbl:84	i386	oldlstat		sys_lstat
arch/x86/entry/syscalls/syscall_32.tbl:195	i386	stat64			sys_stat64			compat_sys_ia32_stat64
arch/x86/entry/syscalls/syscall_32.tbl:196	i386	lstat64			sys_lstat64			compat_sys_ia32_lstat64
arch/x86/entry/syscalls/syscall_32.tbl:197	i386	fstat64			sys_fstat64			compat_sys_ia32_fstat64
arch/x86/entry/syscalls/syscall_32.tbl:300	i386	fstatat64		sys_fstatat64			compat_sys_ia32_fstatat64
arch/alpha/kernel/syscalls/syscall.tbl:224	common	osf_stat			sys_osf_stat
arch/alpha/kernel/syscalls/syscall.tbl:225	common	osf_lstat			sys_osf_lstat
arch/alpha/kernel/syscalls/syscall.tbl:226	common	osf_fstat			sys_osf_fstat

Not sure about ustat/fstatfs/statfs, I suppose those are a different
category, right?

       Arnd

  reply	other threads:[~2026-06-10 17:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10 16:47 Ricardo Robaina
2026-06-10 17:05 ` Arnd Bergmann [this message]
2026-06-10 17:40   ` Ricardo Robaina
2026-06-10 18:13     ` Steve Grubb
2026-06-10 18:54       ` Ricardo Robaina
2026-06-10 19:39       ` Arnd Bergmann
2026-06-10 19:53         ` Ricardo Robaina
2026-06-12  1:20 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=476e0a44-c6fb-4e6a-af56-a9f1d054518a@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=audit@vger.kernel.org \
    --cc=eparis@redhat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=rrobaina@redhat.com \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®