From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9FF81A2C25 for ; Mon, 30 Dec 2024 10:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735553431; cv=none; b=uN4vsiSTtMM82oThpzMy7CxgUeJ82g4YsOrG51CboN1to3jPCrH5OyMWBXu10YfZmpvkZNxRxRH3tjAWb3Dv4HViJ+j4MUEsQoMGBsWa77qazDFjNAYRS3kI9NGNw4mjs+wa+j2Ie53ZxOgT0aX4a+kXJWiLiNkQZaVbxdTlYE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735553431; c=relaxed/simple; bh=nxqVeEVhd/0VomLYsMSOu9dvcfHBsvSA7Tje60a3Fko=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=esuKVKzCmHyBgy1twoKZt6CLefB6OdTZHvzYK9vqL6+frojfa1GEbw6qKqQp4ggxIsH+JXYHNpL9f67Z76TBuKd3xdypyl7gl67EVGYMwNzaLGWxwOudPPp3e3R5TAW/yVErFxBJND746Mb1LmtH/z7YZIevLmhJhZE5WqPOCss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AGN35AdU; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AGN35AdU" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-385df53e559so7111188f8f.3 for ; Mon, 30 Dec 2024 02:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735553427; x=1736158227; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=3ip7pGqXck17wvsrarfD5jYciYFfcRaD6eiqga2iC0A=; b=AGN35AdUuYY43K+Ykrms9JjWfp0Sa7En4gxdvdbbXcrLdljSHwt3ppKrPvaqzXMsx7 eYSLB3xhu+JZNJnHKMNNERJmjHtx6IIenlrUgckSPv2sfq1mKo49dqjM7RPUhyMIxFFL FFY3uhWrkg/6ZDjhK02oSilW2UPOAhJhzKLwYRxla676ynONVSv+yWFo/z7IQaKZfFK9 MRD+y1REkoUb0PGD5IJ9fY0zWwpwqYacZCTCMia4Im7QtTsDBU5DgXr1yg674mnvUcTS ZBaYTkqu+Fd1sg/Umch7hOY8m+IlJTdX0hqS1TdRgOdwabZwASupZI2xzPlyeeJut3PL yChA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735553427; x=1736158227; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3ip7pGqXck17wvsrarfD5jYciYFfcRaD6eiqga2iC0A=; b=LVi8g0WNK3P+9b7txHpEtI1fFxBfA0zdePjaMyGovB1k0ju4SBKKD25ZjHHQJq8COq YcvNu3LJO2XK1jJefczyS+owblFvgXOLFoeQ06qwURfOacDxb1JuXKDToihCBfGKMBE7 KzNr+yyEhQZ5LaR7N4yW+tERxGJdrw2KPj9dewYNqJorlKT+0G+7lHz7sKnsNi1SRoNN xprn2CdIhjy2ZpiZISrWRKZ2bbO4vucro5QlP/PVnSHpOWEpR2HpOWE5S0b7HWaGCOAb 6pULhh0cSP4ujppBQHNEKmMkyipAfMJGDU8w7JtNm9OQafwEumdRN4O+64RjLHx6IkSk YAyw== X-Forwarded-Encrypted: i=1; AJvYcCX8RFvTOcjto10P9IfQhHa8vEP7SLaOYGo8td9X8VGbWRiSdL3h1qg/Fb1pfk/yZdq/PtamWS8v9h9jvrk=@vger.kernel.org X-Gm-Message-State: AOJu0YyY9yDt9hKD0C05i9aD6UAJXj7j9gnJOZeqM1GrvNMXNCcsPtzO rlPYQN6ZwA05lxJ055O9nsiqUaOQEdCTxDSfF0D0Ux7QBud2l2mYTb6RRCjPhPo= X-Gm-Gg: ASbGncsKxduXhtifGkIgu0hD9AdcAm0kPqhn6VVHq1ISZBKOVln0rsY8oN8jXBV5heh yOV4huhP7hNE7syqJv6Y8yDPXXfWXyoRmfRnqZifZqwOhatxb34XQ3cRUQn6VGSdwSYURwPLHnb 32rGB+Gd6aW7GMUa0qsFhdo/v84abwZRRL4Zue2P4zUoRmvKbKee+lJYUn+7rbLC2w+TaiTOYHf hgGxsRrtsvctjsrCr0fM2TKNpJvtKo+x4z5paFWnlKtuvNzwhgA/wGrwWIvC8N2ZPCKoP/L+R6j dIp8gGl7k3lIccqnVKcozBASMtIw7ojgaA== X-Google-Smtp-Source: AGHT+IGxfn0fqFZ1s4ULFUmsRowFykmhDUBGXcv/6abUFPyNNYsgfZIE+tATEya/iQV1N4R4OLW3sQ== X-Received: by 2002:a5d:64a3:0:b0:385:f527:be6d with SMTP id ffacd0b85a97d-38a2240074fmr28284236f8f.36.1735553427163; Mon, 30 Dec 2024 02:10:27 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:883b:3c16:2465:ad55? ([2a01:e0a:982:cbb0:883b:3c16:2465:ad55]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4366127c515sm352845965e9.30.2024.12.30.02.10.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Dec 2024 02:10:26 -0800 (PST) Message-ID: <47738b2b-351b-4df9-a50a-f4dff51441c8@linaro.org> Date: Mon, 30 Dec 2024 11:10:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] drm/panel: xinpeng-xpp055c272: transition to mipi_dsi wrapped functions To: Tejas Vipin , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: quic_jesszhan@quicinc.com, dianders@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20241223052049.419831-1-tejasvipin76@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20241223052049.419831-1-tejasvipin76@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/12/2024 06:20, Tejas Vipin wrote: > Changes the xinpeng-xpp055c272 panel to use multi style functions for > improved error handling. > > Signed-off-by: Tejas Vipin > --- > .../gpu/drm/panel/panel-xinpeng-xpp055c272.c | 185 ++++++++---------- > 1 file changed, 84 insertions(+), 101 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > index 22a14006765e..45a405669593 100644 > --- a/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > +++ b/drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c > @@ -59,90 +59,82 @@ static inline struct xpp055c272 *panel_to_xpp055c272(struct drm_panel *panel) > return container_of(panel, struct xpp055c272, panel); > } > > -static int xpp055c272_init_sequence(struct xpp055c272 *ctx) > +static void xpp055c272_init_sequence(struct mipi_dsi_multi_context *dsi_ctx) > { > - struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > - struct device *dev = ctx->dev; > - > /* > * Init sequence was supplied by the panel vendor without much > * documentation. > */ > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETEXTC, 0xf1, 0x12, 0x83); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETMIPI, > - 0x33, 0x81, 0x05, 0xf9, 0x0e, 0x0e, 0x00, 0x00, > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x44, 0x25, > - 0x00, 0x91, 0x0a, 0x00, 0x00, 0x02, 0x4f, 0x01, > - 0x00, 0x00, 0x37); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETPOWER_EXT, 0x25); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETPCR, 0x02, 0x11, 0x00); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETRGBIF, > - 0x0c, 0x10, 0x0a, 0x50, 0x03, 0xff, 0x00, 0x00, > - 0x00, 0x00); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETSCR, > - 0x73, 0x73, 0x50, 0x50, 0x00, 0x00, 0x08, 0x70, > - 0x00); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETVDC, 0x46); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETPANEL, 0x0b); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETCYC, 0x80); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETDISP, 0xc8, 0x12, 0x30); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETEQ, > - 0x07, 0x07, 0x0B, 0x0B, 0x03, 0x0B, 0x00, 0x00, > - 0x00, 0x00, 0xFF, 0x00, 0xC0, 0x10); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETPOWER, > - 0x53, 0x00, 0x1e, 0x1e, 0x77, 0xe1, 0xcc, 0xdd, > - 0x67, 0x77, 0x33, 0x33); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETECO, 0x00, 0x00, 0xff, > - 0xff, 0x01, 0xff); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETBGP, 0x09, 0x09); > - msleep(20); > - > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETVCOM, 0x87, 0x95); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETGIP1, > - 0xc2, 0x10, 0x05, 0x05, 0x10, 0x05, 0xa0, 0x12, > - 0x31, 0x23, 0x3f, 0x81, 0x0a, 0xa0, 0x37, 0x18, > - 0x00, 0x80, 0x01, 0x00, 0x00, 0x00, 0x00, 0x80, > - 0x01, 0x00, 0x00, 0x00, 0x48, 0xf8, 0x86, 0x42, > - 0x08, 0x88, 0x88, 0x80, 0x88, 0x88, 0x88, 0x58, > - 0xf8, 0x87, 0x53, 0x18, 0x88, 0x88, 0x81, 0x88, > - 0x88, 0x88, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETGIP2, > - 0x00, 0x1a, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, > - 0x00, 0x00, 0x00, 0x00, 0x1f, 0x88, 0x81, 0x35, > - 0x78, 0x88, 0x88, 0x85, 0x88, 0x88, 0x88, 0x0f, > - 0x88, 0x80, 0x24, 0x68, 0x88, 0x88, 0x84, 0x88, > - 0x88, 0x88, 0x23, 0x10, 0x00, 0x00, 0x1c, 0x00, > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > - 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x30, 0x05, > - 0xa0, 0x00, 0x00, 0x00, 0x00); > - mipi_dsi_dcs_write_seq(dsi, XPP055C272_CMD_SETGAMMA, > - 0x00, 0x06, 0x08, 0x2a, 0x31, 0x3f, 0x38, 0x36, > - 0x07, 0x0c, 0x0d, 0x11, 0x13, 0x12, 0x13, 0x11, > - 0x18, 0x00, 0x06, 0x08, 0x2a, 0x31, 0x3f, 0x38, > - 0x36, 0x07, 0x0c, 0x0d, 0x11, 0x13, 0x12, 0x13, > - 0x11, 0x18); > - > - msleep(60); > - > - dev_dbg(dev, "Panel init sequence done\n"); > - return 0; > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETEXTC, 0xf1, 0x12, 0x83); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETMIPI, > + 0x33, 0x81, 0x05, 0xf9, 0x0e, 0x0e, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x44, 0x25, > + 0x00, 0x91, 0x0a, 0x00, 0x00, 0x02, 0x4f, 0x01, > + 0x00, 0x00, 0x37); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETPOWER_EXT, 0x25); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETPCR, 0x02, 0x11, 0x00); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETRGBIF, > + 0x0c, 0x10, 0x0a, 0x50, 0x03, 0xff, 0x00, 0x00, > + 0x00, 0x00); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETSCR, > + 0x73, 0x73, 0x50, 0x50, 0x00, 0x00, 0x08, 0x70, > + 0x00); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETVDC, 0x46); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETPANEL, 0x0b); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETCYC, 0x80); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETDISP, 0xc8, 0x12, 0x30); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETEQ, > + 0x07, 0x07, 0x0b, 0x0b, 0x03, 0x0b, 0x00, 0x00, > + 0x00, 0x00, 0xff, 0x00, 0xC0, 0x10); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETPOWER, > + 0x53, 0x00, 0x1e, 0x1e, 0x77, 0xe1, 0xcc, 0xdd, > + 0x67, 0x77, 0x33, 0x33); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETECO, 0x00, 0x00, 0xff, > + 0xff, 0x01, 0xff); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETBGP, 0x09, 0x09); > + mipi_dsi_msleep(dsi_ctx, 20); > + > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETVCOM, 0x87, 0x95); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETGIP1, > + 0xc2, 0x10, 0x05, 0x05, 0x10, 0x05, 0xa0, 0x12, > + 0x31, 0x23, 0x3f, 0x81, 0x0a, 0xa0, 0x37, 0x18, > + 0x00, 0x80, 0x01, 0x00, 0x00, 0x00, 0x00, 0x80, > + 0x01, 0x00, 0x00, 0x00, 0x48, 0xf8, 0x86, 0x42, > + 0x08, 0x88, 0x88, 0x80, 0x88, 0x88, 0x88, 0x58, > + 0xf8, 0x87, 0x53, 0x18, 0x88, 0x88, 0x81, 0x88, > + 0x88, 0x88, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETGIP2, > + 0x00, 0x1a, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x1f, 0x88, 0x81, 0x35, > + 0x78, 0x88, 0x88, 0x85, 0x88, 0x88, 0x88, 0x0f, > + 0x88, 0x80, 0x24, 0x68, 0x88, 0x88, 0x84, 0x88, > + 0x88, 0x88, 0x23, 0x10, 0x00, 0x00, 0x1c, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x30, 0x05, > + 0xa0, 0x00, 0x00, 0x00, 0x00); > + mipi_dsi_dcs_write_seq_multi(dsi_ctx, XPP055C272_CMD_SETGAMMA, > + 0x00, 0x06, 0x08, 0x2a, 0x31, 0x3f, 0x38, 0x36, > + 0x07, 0x0c, 0x0d, 0x11, 0x13, 0x12, 0x13, 0x11, > + 0x18, 0x00, 0x06, 0x08, 0x2a, 0x31, 0x3f, 0x38, > + 0x36, 0x07, 0x0c, 0x0d, 0x11, 0x13, 0x12, 0x13, > + 0x11, 0x18); > + > + mipi_dsi_msleep(dsi_ctx, 60); > } > > static int xpp055c272_unprepare(struct drm_panel *panel) > { > struct xpp055c272 *ctx = panel_to_xpp055c272(panel); > struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > - int ret; > - > - ret = mipi_dsi_dcs_set_display_off(dsi); > - if (ret < 0) > - dev_err(ctx->dev, "failed to set display off: %d\n", ret); > - > - mipi_dsi_dcs_enter_sleep_mode(dsi); > - if (ret < 0) { > - dev_err(ctx->dev, "failed to enter sleep mode: %d\n", ret); > - return ret; > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi }; > + > + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); > + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); > + if (dsi_ctx.accum_err) { > + dev_err(ctx->dev, "failed to enter sleep mode: %d\n", > + dsi_ctx.accum_err); > + return dsi_ctx.accum_err; > } > > regulator_disable(ctx->iovcc); > @@ -155,17 +147,19 @@ static int xpp055c272_prepare(struct drm_panel *panel) > { > struct xpp055c272 *ctx = panel_to_xpp055c272(panel); > struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > - int ret; > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi }; > > dev_dbg(ctx->dev, "Resetting the panel\n"); > - ret = regulator_enable(ctx->vci); > - if (ret < 0) { > - dev_err(ctx->dev, "Failed to enable vci supply: %d\n", ret); > - return ret; > + dsi_ctx.accum_err = regulator_enable(ctx->vci); > + if (dsi_ctx.accum_err) { I would rather keep ret instead of abusing dsi_ctx.accum_err, but it's already like that in other converted driver so I won't oppose it... > + dev_err(ctx->dev, "Failed to enable vci supply: %d\n", > + dsi_ctx.accum_err); > + return dsi_ctx.accum_err; > } > - ret = regulator_enable(ctx->iovcc); > - if (ret < 0) { > - dev_err(ctx->dev, "Failed to enable iovcc supply: %d\n", ret); > + dsi_ctx.accum_err = regulator_enable(ctx->iovcc); > + if (dsi_ctx.accum_err) { > + dev_err(ctx->dev, "Failed to enable iovcc supply: %d\n", > + dsi_ctx.accum_err); > goto disable_vci; > } > > @@ -175,30 +169,19 @@ static int xpp055c272_prepare(struct drm_panel *panel) > gpiod_set_value_cansleep(ctx->reset_gpio, 0); > > /* T8: 20ms */ > - msleep(20); > + mipi_dsi_msleep(&dsi_ctx, 20); > > - ret = xpp055c272_init_sequence(ctx); > - if (ret < 0) { > - dev_err(ctx->dev, "Panel init sequence failed: %d\n", ret); > - goto disable_iovcc; > - } > - > - ret = mipi_dsi_dcs_exit_sleep_mode(dsi); > - if (ret < 0) { > - dev_err(ctx->dev, "Failed to exit sleep mode: %d\n", ret); > - goto disable_iovcc; > - } > + xpp055c272_init_sequence(&dsi_ctx); > + dev_dbg(ctx->dev, "Panel init sequence done\n"); > > + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); > /* T9: 120ms */ > - msleep(120); > + mipi_dsi_msleep(&dsi_ctx, 120); > + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); > + mipi_dsi_msleep(&dsi_ctx, 50); > > - ret = mipi_dsi_dcs_set_display_on(dsi); > - if (ret < 0) { > - dev_err(ctx->dev, "Failed to set display on: %d\n", ret); > + if (dsi_ctx.accum_err) > goto disable_iovcc; > - } > - > - msleep(50); > > return 0; > > @@ -206,7 +189,7 @@ static int xpp055c272_prepare(struct drm_panel *panel) > regulator_disable(ctx->iovcc); > disable_vci: > regulator_disable(ctx->vci); > - return ret; > + return dsi_ctx.accum_err; > } > > static const struct drm_display_mode default_mode = { Otherwise looks good Reviewed-by: Neil Armstrong Neil