mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kumar Gala <galak@codeaurora.org>
To: "Ivan T. Ivanov" <ivan.ivanov@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Russell King <linux@arm.linux.org.uk>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 5/7] arm64: dts: qcom: Add 8x16 chipset SPMI PMIC's nodes
Date: Wed, 1 Apr 2015 15:00:36 -0500	[thread overview]
Message-ID: <477459F0-90E0-4281-BFFF-F4F73BFCEE85@codeaurora.org> (raw)
In-Reply-To: <1427900715-26273-6-git-send-email-ivan.ivanov@linaro.org>


On Apr 1, 2015, at 10:05 AM, Ivan T. Ivanov <ivan.ivanov@linaro.org> wrote:

> PM9816 has 2 SPMI devices per physical package. Add PMIC configuration
> nodes including sub-function device nodes and include them in boards,
> which are using 8x16 based chipset.
> 
> PM9816 sub-function devices include:
> 
> * GPIO block, with 4 pins
> * MPP block, with 4 pins
> * Volatage ADC (VADC), with multiple inputs
> * Thermal sensor device, which is using on chip VADC
>  channel report PMIC die temperature.
> * Power key device, which is responsible for clean system
>  reboot or shutdown
> * RTC device
> 
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi |  1 +
> arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi |  1 +
> arch/arm64/boot/dts/qcom/pm8916.dtsi      | 93 +++++++++++++++++++++++++++++++
> 3 files changed, 95 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/pm8916.dtsi
> 
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> index 703a4f1..58f0055f 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> @@ -12,6 +12,7 @@
>  */
> 
> #include "msm8916.dtsi"
> +#include "pm8916.dtsi"
> 
> / {
> 	aliases {
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi
> index bea871b..a1aa0b2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi
> @@ -12,6 +12,7 @@
>  */
> 
> #include "msm8916.dtsi"
> +#include "pm8916.dtsi"
> 
> / {
> 	aliases {
> diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> new file mode 100644
> index 0000000..2a5ad2c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> @@ -0,0 +1,93 @@
> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +&spmi_bus {
> +
> +	usid0: pm8916@0 {
> +		compatible ="qcom,spmi-pmic";
> +		reg = <0x0 SPMI_USID>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		rtc@6000 {
> +			compatible = "qcom,pm8941-rtc";
> +			reg = <0x6000 0x6100>;
> +			reg-names = "rtc", "alarm";
> +			interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
> +		};
> +
> +		pwrkey@800 {
> +			compatible = "qcom,pm8941-pwrkey";
> +			reg = <0x800>;
> +			interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> +			debounce = <15625>;
> +			bias-pull-up;
> +		};
> +
> +		pm8916_gpios: gpios@c000 {
> +			compatible = "qcom,pm8916-gpio";
> +			reg = <0xc000 0x400>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupts = <0 0xc0 0 0>, <0 0xc1 0 0>, <0 0xc2 0 0>, <0 0xc3 0 0>;

please cleanup level/edge cell values to use defines

> +		};
> +
> +		pm8916_mpps: mpps@a000 {
> +			compatible = "qcom,pm8916-mpp";
> +			reg = <0xa000 0x400>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupts = <0 0xa0 0 0>, <0 0xa1 0 0>, <0 0xa2 0 0>, <0 0xa3 0 0>;

please cleanup level/edge cell values to use defines

> +		};
> +
> +		pm8916_temp: temp-alarm@2400 {
> +			compatible = "qcom,spmi-temp-alarm";
> +			reg = <0x2400 0x100>;
> +			interrupts = <0 0x24 0 IRQ_TYPE_EDGE_RISING>;
> +			io-channels = <&pm8916_vadc VADC_DIE_TEMP>;
> +			io-channel-names = "thermal";
> +			#thermal-sensor-cells = <0>;
> +		};
> +
> +		pm8916_vadc: vadc@3100 {
> +			compatible = "qcom,spmi-vadc";
> +			reg = <0x3100 0x100>;
> +			interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			#io-channel-cells = <1>;
> +
> +			usb_in {
> +				reg = <VADC_USBIN>;
> +				qcom,pre-scaling = <1 10>;
> +			};
> +			vph_pwr {
> +				reg = <VADC_VSYS>;
> +				qcom,pre-scaling = <1 3>;
> +			};
> +			die_temp {
> +				reg = <VADC_DIE_TEMP>;
> +			};
> +			ref_625mv {
> +				reg = <VADC_REF_625MV>;
> +			};
> +			ref_1250v {
> +				reg = <VADC_REF_1250MV>;
> +			};
> +			ref_gnd {
> +				reg = <VADC_GND_REF>;
> +			};
> +			ref_vdd {
> +				reg = <VADC_VDD_VADC>;
> +			};
> +		};
> +	};
> +
> +	usid1: pm8916@1 {
> +		compatible ="qcom,spmi-pmic”;

fix whitespace after ‘='

> +		reg = <0x1 SPMI_USID>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +	};
> +};
> --
> 1.9.1
> 

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


  reply	other threads:[~2015-04-01 20:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 15:05 [PATCH 0/7] ARM: dts: qcom: Add more device coniguration nodes Ivan T. Ivanov
2015-04-01 15:05 ` [PATCH 1/7] ARM: dts: qcom: Add PM8841 functions device nodes Ivan T. Ivanov
2015-04-01 19:54   ` Kumar Gala
2015-04-08  7:07     ` Ivan T. Ivanov
2015-04-01 15:05 ` [PATCH 2/7] ARM: dts: qcom: Add PM8941 " Ivan T. Ivanov
2015-04-01 19:58   ` Kumar Gala
2015-04-01 15:05 ` [PATCH 3/7] ARM: dts: qcom: Add PMA8084 " Ivan T. Ivanov
2015-04-01 15:05 ` [PATCH 4/7] arm64: dts: qcom: Add SPMI PMIC Arbiter node for MSM8916 Ivan T. Ivanov
2015-04-01 19:58   ` Kumar Gala
2015-04-01 15:05 ` [PATCH 5/7] arm64: dts: qcom: Add 8x16 chipset SPMI PMIC's nodes Ivan T. Ivanov
2015-04-01 20:00   ` Kumar Gala [this message]
2015-04-01 15:05 ` [PATCH 6/7] arm64: dts: qcom: Add MSM8916 restart device node Ivan T. Ivanov
2015-04-01 15:05 ` [PATCH 7/7] arm64: dts: qcom: Add initial set of PMIC and SoC pins for APQ8016 SBC board Ivan T. Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=477459F0-90E0-4281-BFFF-F4F73BFCEE85@codeaurora.org \
    --to=galak@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=ivan.ivanov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®