mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Adrian Bunk <bunk@kernel.org>,
	Michael Tokarev <mjt@tls.msk.ru>
Subject: Re: [PATCH 1/1] mxser, remove it
Date: Sat, 29 Dec 2007 17:09:44 +0100	[thread overview]
Message-ID: <47767148.2010209@gmail.com> (raw)
In-Reply-To: <20071229022329.39f6162a@the-village.bc.nu>

On 12/29/2007 03:23 AM, Alan Cox wrote:
>>> +static int mxvar_baud_table[] = {
>>> +	0, 50, 75, 110, 134, 150, 200, 300, 600, 1200, 1800, 2400,
>>> +	4800, 9600, 19200, 38400, 57600, 115200, 230400, 460800, 921600
>>> +};
>>> +static unsigned int mxvar_baud_table1[] = {
>>> +	0, B50, B75, B110, B134, B150, B200, B300, B600, B1200, B1800, B2400,
>>> +	B4800, B9600, B19200, B38400, B57600, B115200, B230400, B460800, B921600
>>> +};
>> Constify both, if possible?
> 
> These are not portable - baud rate tables vary for some platforms. No
> driver should be touching Bxxx coding itself any more. Use the tty_
> functions to decode and encode baud rates.

Thanks for reviews, I'll post fixes for all the issues as separate patches.

  reply	other threads:[~2007-12-29 16:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28 10:09 Jiri Slaby
2007-12-29  1:29 ` Jan Engelhardt
2007-12-29  2:23   ` Alan Cox
2007-12-29 16:09     ` Jiri Slaby [this message]
2007-12-29  2:29 ` Alan Cox
  -- strict thread matches above, loose matches on Subject: below --
2007-12-27 13:38 Jiri Slaby
2007-12-27 15:19 ` Michael Tokarev
2007-12-27 17:21   ` Adrian Bunk
2007-12-27 20:54     ` Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47767148.2010209@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bunk@kernel.org \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjt@tls.msk.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®