From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E4411F473A; Tue, 13 May 2025 08:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747123725; cv=none; b=t+/K4wUpnIVUqJ+6kjCWit9ppLutcedAUP3K5XGOgh0zEF2dlv9NoBKY6wheLr9TJdrlXDJeOpVb6+NlMdUwJ5wi0FRPFm25Oq/9i0AZGQYy22rgM1oCRE3VRdZD3ZQ//H6lnPPpDCQoAOCu3YrgJWmZFMYJBoATBHSEWGJVIGs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747123725; c=relaxed/simple; bh=qpu4GWk38f9wakUkXBPq5Dr+ab4bLpt3174rgWFnguE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=N/kbHZzTUoc8WbXJow7/AfDEibofMWB7k+OlkGr4sFE26lnayLkBak0V9LPGut6oC1cGAQEElsjB9SOV8JxvN3V/ImcPVMYV+SOV4OiP9LxVQjkDkYv9MuVXwggAZXEAH8w8+rYoQZBMCPmj7OjOdeOZWVYszR6CE3EcqKQ7bus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=skXMQBTd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="skXMQBTd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F7EAC4CEE4; Tue, 13 May 2025 08:08:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747123724; bh=qpu4GWk38f9wakUkXBPq5Dr+ab4bLpt3174rgWFnguE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=skXMQBTdAo3l4fHmuiur7V2ZxjECppgZqz8+4zOTYDGB17yB3bn+074AlWY5tgwgV pc52OUFSlCQLOEYqg3JL0V2TT901jZGVqCX9W66fO2mEa/Ha9qMdIJI9sXkWDdftRb A1izmCJPVm1ulXr7k5uqDizk8Sn/4iAoal9akV8dlOXXay63EYBFRDahSi3zs/sHD6 pjG4Fx1aGfiK1WazcxkmmyfAgKpe7VChUtBZTy2HkCSLyi8ohwUqybmj9+DQiFbIe9 z0uMUeAsvgNxGpPhV2r2rCrEEqyjodOOYg6jId9nAwUDNDDtUe2ryOmrbtkBc+SwGG 01hcn/ofgZcog== Message-ID: <4783c1aa-d918-4194-90d7-ebc69ddbb789@kernel.org> Date: Tue, 13 May 2025 10:08:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/2] net: pse-pd: Add Si3474 PSE controller driver To: Piotr Kubik , Oleksij Rempel , Kory Maincent , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <036e6a6c-ba45-4288-bc2a-9fd8d860ade6@adtran.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <036e6a6c-ba45-4288-bc2a-9fd8d860ade6@adtran.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/05/2025 00:06, Piotr Kubik wrote: > +/* Parse pse-pis subnode into chan array of si3474_priv */ > +static int si3474_get_of_channels(struct si3474_priv *priv) > +{ > + struct device_node *pse_node, *node; > + struct pse_pi *pi; > + u32 pi_no, chan_id; > + s8 pairset_cnt; > + s32 ret = 0; > + > + pse_node = of_get_child_by_name(priv->np, "pse-pis"); > + if (!pse_node) { > + dev_warn(&priv->client[0]->dev, > + "Unable to parse DT PSE power interface matrix, no pse-pis node\n"); > + return -EINVAL; > + } > + > + for_each_child_of_node(pse_node, node) { Use scoped variant. One cleanup less. > + if (!of_node_name_eq(node, "pse-pi")) > + continue; ... > + > + ret = i2c_smbus_read_byte_data(client, FIRMWARE_REVISION_REG); > + if (ret < 0) > + return ret; > + fw_version = ret; > + > + ret = i2c_smbus_read_byte_data(client, CHIP_REVISION_REG); > + if (ret < 0) > + return ret; > + > + dev_info(dev, "Chip revision: 0x%x, firmware version: 0x%x\n", dev_dbg or just drop. Drivers should be silent on success. > + ret, fw_version); > + > + priv->client[0] = client; > + i2c_set_clientdata(client, priv); > + > + priv->client[1] = i2c_new_ancillary_device(priv->client[0], "slave", > + priv->client[0]->addr + 1); > + if (IS_ERR(priv->client[1])) > + return PTR_ERR(priv->client[1]); > + > + ret = i2c_smbus_read_byte_data(priv->client[1], VENDOR_IC_ID_REG); > + if (ret < 0) { > + dev_err(&priv->client[1]->dev, "Cannot access slave PSE controller\n"); > + goto out_err_slave; > + } > + > + if (ret != SI3474_DEVICE_ID) { > + dev_err(&priv->client[1]->dev, > + "Wrong device ID for slave PSE controller: 0x%x\n", ret); > + ret = -ENXIO; > + goto out_err_slave; > + } > + > + priv->np = dev->of_node; > + priv->pcdev.owner = THIS_MODULE; > + priv->pcdev.ops = &si3474_ops; > + priv->pcdev.dev = dev; > + priv->pcdev.types = ETHTOOL_PSE_C33; > + priv->pcdev.nr_lines = SI3474_MAX_CHANS; > + > + ret = devm_pse_controller_register(dev, &priv->pcdev); > + if (ret) { No need for {} > + return dev_err_probe(dev, ret, > + "Failed to register PSE controller\n"); No cleanup here? That's odd. > + } > + > + return ret; return 0 > + > +out_err_slave: > + i2c_unregister_device(priv->client[1]); > + return ret; > +} > + > +static void si3474_i2c_remove(struct i2c_client *client) > +{ > + struct si3474_priv *priv = i2c_get_clientdata(client); > + > + i2c_unregister_device(priv->client[1]); So you first unregister i2c device and then unregister pse controller. Feels like possible issues, difficult to debug.... Use devm reset wrapper for that. Best regards, Krzysztof