mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chen, Yu C" <yu.c.chen@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: <x86@kernel.org>, <linux-kernel@vger.kernel.org>,
	<tglx@kernel.org>, <bp@alien8.de>, <mingo@redhat.com>,
	<dave.hansen@linux.intel.com>, <hpa@zytor.com>,
	<fenghuay@nvidia.com>, <babu.moger@amd.com>,
	<anil.keshavamurthy@broadcom.com>, <chen.yu@linux.dev>,
	Hongyu Ning <hongyu.ning@linux.intel.com>, <tony.luck@intel.com>
Subject: Re: [PATCH v5 02/10] x86/topology: Export topo_lookup_cpuid() for resctrl use
Date: Tue, 14 Jul 2026 23:45:07 +0800	[thread overview]
Message-ID: <47845d25-e1c4-4887-a7ae-fd0a3fa6f223@intel.com> (raw)
In-Reply-To: <baade700-73c8-47f8-b747-3e946dfffd1c@intel.com>

Hi Reinette,

On 7/11/2026 7:35 AM, Reinette Chatre wrote:
> Hi Chenyu,
> 
> Since this targets a different subsystem, could you please re-order the series
> to have this as first patch to make it obvious that it does not depend on
> anything in this series.
> 

OK, will do.

> On 7/1/26 6:45 AM, Chen Yu wrote:
>> Make topo_lookup_cpuid() accessible outside of topology.c and add its
>> declaration to asm/apic.h. This is needed by Enhanced RDT (ERDT) to
>> resolve x2APIC IDs from ACPI tables to logical CPU numbers.
> 
> The first sentence of this changelog describes verbatim what can clearly
> be seen from the patch self without any context or problem description about
> why this change is needed.
> tip changelogs always need to start with *why* the patch is needed before
> describing the change self. For more details about changelog requirements, please
> see "Changelog" in Documentation/process/maintainer-tip.rst
> 

OK, let me revisit the commit log of this patch set to revise it.

>>
>> No functional change expected.
>>
>> Tested-by: Hongyu Ning <hongyu.ning@linux.intel.com>
>> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> 
> Also please follow "Ordering of commit tags" found in
> Documentation/process/maintainer-tip.rst for all patches in this series.
> 

Thank you for pointing that out; I wasn't aware. Let me rearrange the order
of this patch set.

thanks,
Chenyu

  reply	other threads:[~2026-07-14 15:45 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 13:44 [PATCH v5 00/10] Introduce MMIO-based CMT access for Enhanced RDT Chen Yu
2026-07-01 13:45 ` [PATCH v5 01/10] x86/resctrl: Require 64-bit x86 for resctrl support Chen Yu
2026-07-01 13:45 ` [PATCH v5 02/10] x86/topology: Export topo_lookup_cpuid() for resctrl use Chen Yu
2026-07-10 23:35   ` Reinette Chatre
2026-07-14 15:45     ` Chen, Yu C [this message]
2026-07-01 13:45 ` [PATCH v5 03/10] x86/resctrl: Parse ACPI ERDT table and save CACD cpumask for RMDD domains Chen Yu
2026-07-10 23:42   ` Reinette Chatre
2026-07-14 15:19     ` Chen, Yu C
2026-07-14 16:13       ` Reinette Chatre
2026-07-14 16:33         ` Chen, Yu C
2026-07-01 13:45 ` [PATCH v5 04/10] x86/resctrl: Attach ACPI ERDT information to L3 mon domain on CPU online Chen Yu
2026-07-10 23:45   ` Reinette Chatre
2026-07-14  8:51     ` Chen, Yu C
2026-07-14 16:13       ` Reinette Chatre
2026-07-14 16:24         ` Chen, Yu C
2026-07-01 13:46 ` [PATCH v5 05/10] x86/resctrl: Parse ACPI CMRC table Chen Yu
2026-07-10 23:46   ` Reinette Chatre
2026-07-14 16:27     ` Chen, Yu C
2026-07-01 13:46 ` [PATCH v5 06/10] x86/resctrl: Replace "msr" in monitoring data identifiers Chen Yu
2026-07-10 23:47   ` Reinette Chatre
2026-07-01 13:46 ` [PATCH v5 07/10] x86/resctrl: Refactor the monitor read function Chen Yu
2026-07-01 13:47 ` [PATCH v5 08/10] fs/resctrl: Do not invoke smp_processor_id() in preemptible context Chen Yu
2026-07-10 23:48   ` Reinette Chatre
2026-07-01 13:47 ` [PATCH v5 09/10] x86/resctrl: Introduce helpers to read L3 occupancy via MMIO Chen Yu
2026-07-10 23:53   ` Reinette Chatre
2026-07-01 13:47 ` [PATCH v5 10/10] x86/resctrl: Enable " Chen Yu
2026-07-10 23:55   ` Reinette Chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47845d25-e1c4-4887-a7ae-fd0a3fa6f223@intel.com \
    --to=yu.c.chen@intel.com \
    --cc=anil.keshavamurthy@broadcom.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=chen.yu@linux.dev \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghuay@nvidia.com \
    --cc=hongyu.ning@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox