From: Coly Li <colyli@suse.de>
To: Geliang Tang <geliangtang@gmail.com>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Shaohua Li <shli@kernel.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dm bio prison: use rb_entry()
Date: Fri, 20 Jan 2017 23:12:59 +0800 [thread overview]
Message-ID: <478774bc-7af1-58a6-7c3e-36745249d61b@suse.de> (raw)
In-Reply-To: <edf46b9e198bf2b0c0a31a9b99da6e59e880cdb9.1484816756.git.geliangtang@gmail.com>
On 2017/1/20 下午10:36, Geliang Tang wrote:
> To make the code clearer, use rb_entry() instead of container_of() to
> deal with rbtree.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/md/dm-bio-prison.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-bio-prison.c b/drivers/md/dm-bio-prison.c
> index 03af174..a2c8a9e 100644
> --- a/drivers/md/dm-bio-prison.c
> +++ b/drivers/md/dm-bio-prison.c
> @@ -115,7 +115,7 @@ static int __bio_detain(struct dm_bio_prison *prison,
>
> while (*new) {
> struct dm_bio_prison_cell *cell =
> - container_of(*new, struct dm_bio_prison_cell, node);
> + rb_entry(*new, struct dm_bio_prison_cell, node);
>
> r = cmp_keys(key, &cell->key);
>
>
Acked-by: Coly Li <colyli@suse.de>
next prev parent reply other threads:[~2017-01-20 15:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 14:36 [PATCH] 6lowpan: " Geliang Tang
2017-01-20 14:36 ` [PATCH] dm bio prison: " Geliang Tang
2017-01-20 15:12 ` Coly Li [this message]
2017-05-06 15:39 ` [PATCH v2] " Geliang Tang
2017-01-20 14:36 ` [PATCH] drm/i915/error: " Geliang Tang
2017-01-23 9:10 ` [Intel-gfx] " Chris Wilson
2017-01-20 14:36 ` [PATCH] drm/nouveau/client: " Geliang Tang
2017-01-20 14:36 ` [PATCH] net/mlx4: " Geliang Tang
2017-01-22 7:48 ` Leon Romanovsky
2017-01-22 14:42 ` Geliang Tang
2017-01-22 19:05 ` Leon Romanovsky
2017-01-22 21:48 ` David Miller
2017-01-22 21:48 ` David Miller
2017-01-22 21:47 ` [PATCH] 6lowpan: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478774bc-7af1-58a6-7c3e-36745249d61b@suse.de \
--to=colyli@suse.de \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=geliangtang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®