From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753041AbcANMYg (ORCPT ); Thu, 14 Jan 2016 07:24:36 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:49648 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbcANMYf (ORCPT ); Thu, 14 Jan 2016 07:24:35 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Daniel Lezcano , Thomas Gleixner , linux-kernel@vger.kernel.org, Stefan Agner , Xiubo Li , Sascha Hauer , Shawn Guo Subject: Re: [PATCH] clocksource: ftm: select CLKSRC_MMIO Date: Thu, 14 Jan 2016 13:23:44 +0100 Message-ID: <4788720.mjKklOJssF@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <56976994.2060205@linaro.org> References: <11970328.RVc8t0Mk1C@wuerfel> <56976994.2060205@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:HtgLfHe8qNXRNJYMkVn+x+wHVB9oYlqMOTtcL2PONfJ2ebiWjvK 0uM7UNraqnGbdxIrQQTIEqT/hq2rC9ZSiMdqmGC6FKm7HFeWQ1vrHuL8O8+7867jSe0reCr yEEljfMvFF+/kw/TsiePyY5+WaJYUzlT3nzKs4w8d2yj6bZt1QTBnugeJfqAXqB/f1dJPBA LnPei5BrpO8HmFLu06hmg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Br/tB7MpN2c=:xzJzKD9saKw9ADbwgFha26 tG05iN6XWGYsQBbk06a3NblA2kE+/zUODart2b2v2NuD15ohbZhf6/5M4GJ1OHKEHG+kOfwqd aCH2Fdk47JhjBYZrUKKX5jJBKxUyu+M+EZxc02kW0v0mG27zJE7puxKQ6qin9Uu8bSEdJLJST mvZ0SNJUEEvKZOTQh8EGhSaTnHqmghucxBGW4i2q3aQ/6At6XuHvafFOv+P/UrdlR5oxAWXpz XHH/ZcF0Fd693PIFsr8c7aubw+HN3MTKpNCrwqPzvf+0v8T1w2t26jamdG/iTllGkzF65L7mq h4rL3EuC2HiHgHaeXNi0bkYcoUelZV3ORTrLi7wYmcxl1KLaHXFLOjbyMRYoBnVyc99woSjaF eoLS4/MRjLTTlMnUZQ9YFLKW5JdzQ36vwKwD/B8pTZ51WvyJ9CQIJBOxRlkHDCGmuGNorUOjM YYu6NmksTn/b3bfiONKB9Gq/VO4dKLW+Vm3mPhbuZ4/TjShnN7mLjmUwgWjzFma5C+OelqXvm o5NMfbSefGyGtgs1KYnu2xW89oQWORoiUZ+hKm3O8tJJrsngvYycx3++tGBya0CoarZ7apJtd tm2x1FevbwBVpz87SAhN4+oJFmkxUSOV/G3Paxakm53QgcHXdcBjt2nld0XQS+DUZ2NosoW9s 4KSai4h7KqkJKfudenvznSKC4JdR8g4kqlv3lie+NkjpUIANYmJnb3L51p3I+htYy5FanGkC6 JNz4rP9be1tqs7T/ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 14 January 2016 10:25:40 Daniel Lezcano wrote: > On 01/14/2016 12:02 AM, Arnd Bergmann wrote: > > The ftm clocksource driver does not build if CLKSRC_MMIO is disabled: > > > > drivers/built-in.o: In function `ftm_timer_init': > > (init.text+0xd324): undefined reference to `clocksource_mmio_init' > > (init.text+0xd484): undefined reference to `clocksource_mmio_readl_up' > > > > This adds the same 'select' statement that the other similar drivers > > use. Prior to allowing this driver to be enabled with COMPILE_TEST, > > it was apparently unused. I'm not entirely sure who is using this > > hardware, but it certainly can't hurt to ensure it builds cleanly. > > Hi Arnd, > > Thanks for the fix. It is already in Thomas's tree [1]. Ok, thanks for fixing it already! I'll mark this one as superceded in my randconfig testing git tree then and will drop it as soon as yours is merged. Arnd