From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754195AbbLOTs1 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Dec 2015 14:48:27 -0500
Received: from mta02.ornl.gov ([128.219.177.12]:24247 "EHLO mta02.ornl.gov"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752545AbbLOTsZ convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Dec 2015 14:48:25 -0500
X-SG: RELAYLIST
X-IronPort-AV: E=Sophos;i="5.20,433,1444708800"; 
   d="scan'208";a="94313367"
From: "Simmons, James A." <simmonsja@ornl.gov>
To: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
CC: "'Dan Carpenter'" <dan.carpenter@oracle.com>,
        James Simmons <jsimmons@infradead.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        Andreas Dilger <andreas.dilger@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Oleg Drokin <oleg.drokin@intel.com>,
        Amir Shehata <amir.shehata@intel.com>,
        "lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>
Subject: RE: [PATCH 13/40] staging: lustre: Dynamic LNet Configuration (DLC)
 show command
Thread-Topic: [PATCH 13/40] staging: lustre: Dynamic LNet Configuration (DLC)
 show command
Thread-Index: AQHRLPOSs02Aw2T1LUmyysw/D3E4PJ7Mbd/AgABeewD//7wAoA==
Date: Tue, 15 Dec 2015 19:48:22 +0000
Message-ID: <478967481871457488a1ea289237c7ab@EXCHCS32.ornl.gov>
References: <1448062576-23757-1-git-send-email-jsimmons@infradead.org>
 <1448062576-23757-14-git-send-email-jsimmons@infradead.org>
 <20151202112055.GM18797@mwanda>
 <944b6e806bc44a3fa4d6d5e1904a894a@EXCHCS32.ornl.gov>
 <20151215184842.GC16129@kroah.com>
In-Reply-To: <20151215184842.GC16129@kroah.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [128.219.12.132]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>On Tue, Dec 15, 2015 at 06:14:19PM +0000, Simmons, James A. wrote:
>>   
>> >>  struct libcfs_ioctl_hdr {
>> >>  	__u32 ioc_len;
>> >> @@ -87,6 +88,13 @@ do {						    \
>> >>  	data.ioc_hdr.ioc_len = sizeof(data);			\
>> >>  } while (0)
>> >>  
>> >> +#define LIBCFS_IOC_INIT_V2(data, hdr)			\
>> >> +do {							\
>> >> +	memset(&(data), 0, sizeof(data));		\
>> >> +	(data).hdr.ioc_version = LIBCFS_IOCTL_VERSION2;	\
>> >> +	(data).hdr.ioc_len = sizeof(data);		\
>> >> +} while (0)
>> >> +
>> >
>> >Do we really need this?
>> 
>> Would you be okay if this was a inline function? This is used by user
>> land and kernel space code.
>
>Then your code is broken, please never do that.

This brings up a good point. This header doesn't contain structures for userland so it is a uapi
type header.  Should such headers only contain data structures?