From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@suse.de>, Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] x86_64: check MSR to get MMCONFIG for AMD Family 10h Opteron
Date: Tue, 15 Jan 2008 10:42:37 -0500 [thread overview]
Message-ID: <478CD46D.5080104@zytor.com> (raw)
In-Reply-To: <200801141336.35351.yinghai.lu@sun.com>
Yinghai Lu wrote:
> +
> + address = 0xc0010058;
> + if (rdmsr_safe(address, &low, &high))
> + return NULL;
> +
NAK. Add the symbolic MSR name to asm-x86/msr-index.h and use the
symbolic name in the code, please.
-hpa
next prev parent reply other threads:[~2008-01-15 15:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200801141331.45898.yinghai.lu@sun.com>
2008-01-14 21:35 ` [PATCH 1/3] x86_64: check and enable MMCONFIG for AMD Family 10h Opteron v2 Yinghai Lu
2008-01-14 21:36 ` [PATCH 2/3] x86_64: check MSR to get MMCONFIG for AMD Family 10h Opteron Yinghai Lu
2008-01-14 21:37 ` [PATCH 3/3] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG is used Yinghai Lu
2008-01-15 15:42 ` H. Peter Anvin [this message]
[not found] ` <200801151354.02859.yinghai.lu@sun.com>
2008-01-15 21:56 ` [PATCH 1/4] x86: msr for AMD Fam 10h mmio Yinghai Lu
[not found] ` <200801151357.27231.yinghai.lu@sun.com>
2008-01-15 21:58 ` [PATCH 3/4] x86_64: check MSR to get MMCONFIG for AMD Family 10h Opteron v3 Yinghai Lu
2008-01-15 22:00 ` [PATCH 4/4] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG is used Yinghai Lu
2008-01-15 22:01 ` [PATCH 2/4] x86_64: check and enable MMCONFIG for AMD Family 10h Opteron v3 Yinghai Lu
2008-01-18 12:51 ` [PATCH 1/4] x86: msr for AMD Fam 10h mmio Ingo Molnar
2008-01-15 22:02 ` [PATCH 0/4] x86_64:amd fam10h mmconf v3 Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478CD46D.5080104@zytor.com \
--to=hpa@zytor.com \
--cc=Yinghai.Lu@Sun.COM \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome