From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9E713F44CD for ; Tue, 25 Aug 2026 10:03:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787652202; cv=none; b=ZEFNLGfUM+1Y5gTsmH0Hxeqy0r79VleCv30SmYoQG++rhQgBP1hV/jYe0SEhjeDMixvWfiv23Frd4vBffPPB8zgHHcm0pFXZzfxMwAFbaJBXom3PhJSHWorW5R3zkNgYy+epZYT1vCUi7fjPRlEBl3Xe0DXc2HEns+pb0uyDTcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787652202; c=relaxed/simple; bh=uhN4fxJ15enqo3k8CkDLZlRghvRaPv3HpnOP6VDNWkc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k8thGVcUZHs13uidJgYyTDl/Ct08DAsoucyzeUeAgxjjXx4DVLyFQkC428N8BNZucdP3fJbtbFqPFK+e9dY3yQ1D6f+hsKr8gf+oTKFQWGKOeO08zRufY/vVvq4ziluI2ROr7w9YH776ZBe2qPZew/OozQfuCwM+S006cDmD24c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CA4Tm3Lf; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FL0L4TEw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CA4Tm3Lf"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FL0L4TEw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787652199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NUhW54Gf8EXfhXYKN6isHtSeMLz3jtca0/EX8wxX+Ac=; b=CA4Tm3LfWYsZQNxcboRGXrkD0uYIs9045/KQPdFeXxWexH+7ClPuuq2S7xM/Xsxdc7KYrB Yndp57oyQlhU98GPJX1byJt6iLd3LcMsh9tWo/ze1otwZ2gJAA+krD40qC/mnOk/mPy85O ZFk8HW0bwl49cesBuw/H0ASxhAnK1xA= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-524-T2zTrx43PXmtcrWm850PoQ-1; Tue, 25 Aug 2026 06:03:18 -0400 X-MC-Unique: T2zTrx43PXmtcrWm850PoQ-1 X-Mimecast-MFC-AGG-ID: T2zTrx43PXmtcrWm850PoQ_1787652196 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-c217f249fa1so488605166b.0 for ; Tue, 25 Aug 2026 03:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787652196; x=1788256996; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=NUhW54Gf8EXfhXYKN6isHtSeMLz3jtca0/EX8wxX+Ac=; b=FL0L4TEwZPqy4XIQGN+cT+RT6R1kvMehXCRUH+tSyz0+a+iJHy6HGK7Bl+0aemusqQ U+HXqyuQ961m79bJu4KxkODXKz3Qu6FVQWU3H7zeuMyjBW5vYoCBjgXkazHiL2eP/ZNB zhVn7+PA0q4aqrQ6wskhgzGRsFXUA1Ds2jPR8MU+AJ4q+b+iTHw7Tz0Ly7Wq2Zixhf/s 2yrsztm/IBKuGydIMie/mWwta0YhyLMh+l+qrd7PRKuUKDuoPe7+LIlzvXnVLyD+VGaF SUb7OjfyTBInEgYChYh4a0ORvBFFniX5K0p48+fj9JDyY/08TOKSpngw7ir7pWRM4RBC xMSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787652196; x=1788256996; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NUhW54Gf8EXfhXYKN6isHtSeMLz3jtca0/EX8wxX+Ac=; b=kzWnKcKod3y8RjMplECQt1leot2rmLDlMVIL5FW/cPHAs/20B8eheQ8ZPVmw7EHb3l otp3PAzfWXEOng3PmKextbEuYoIZOLKLKwPCxBb4PDj9KdDAmC+Kfrr+gYpk1OkilHtD vCkpjHguoxttA/ploO2wY2vGMRGHTt3WpP2NKtehTFOrTo25unWSoQLdzax0gy+XCxQw B453jcwiuuA5T/yNFCdJGpBFoXfT7RWuS6j+5PkTjeycjioo1P4hazijRT2970CsS5j6 EWfOxLfDbm5nbhnpECqaCVhflEkdnfoXBWY9H0+coAaWqATgBrUAWcm7dxVGXeVEWecY JGQA== X-Forwarded-Encrypted: i=1; AHgh+RrVS17E084ZxQeOeKCSCpVo5RvhGmOlQ/dvgwRgGxRBJzdKsWK3jhY5uKnvpOMSc0iWpofpWFCskCKtTL8=@vger.kernel.org X-Gm-Message-State: AFuF++ndjWJIz+H6AZD8olvZqOk7uQ/8wujwnJMC+n/cnjwXv+o+F1rc kn9F9RRswVRT9gBU13cJbYXLXM9YxJ6LjZ5xhSLG0f/oz5oRzL9yYiUhOenJOZG9MgTMc6lN30s WV6DwI5UH9yvt6yGv+DDOFMuYt0HkJ/EFLCHpzU3CG6yBYFbUDXZk5edMbzPdS2cxlw== X-Gm-Gg: AR+sD100v9enfLXX8Cw6omWDanHv4ULvCo8Mgexlds9PNcxvyzUvvfF0p+d42sqOHvW h7Za2oTgRnJ+WqXJN3GeCfcOdPGDEs7LsJAqw/L8d5wE8LPnx0IauNNdlq058AludtYG610JrgG OuPGe00JMQTodZJi060E6F3J8Tp+aF8ytIpOV+UAEJ4TVKh9F9zcKANuyKBWbUS0JQVDFhWDhNe dAGubIYJmpMJ4uYu3GOzl8j3Vz6M/LyOcKozknOGyf3sG3ScM2KTP3uZHXrWVTehqa/UzWXZo5c o1mynrkdtAulHAMU/PAVf3860DC+AYhJRJgx/pAOnr1Q0ucsQs1ExNBcyUci16bX3popF/mSwOl Fxgpk6wVimelUlTceGYtK4yJQ4CdvDCSFhUEvA2szakEXBxt9acL2WyPc3hdh5Eg9mJ88/ptz X-Received: by 2002:a17:907:a089:b0:c21:450d:cd88 with SMTP id a640c23a62f3a-c24924b8000mr2757838566b.6.1787652195915; Tue, 25 Aug 2026 03:03:15 -0700 (PDT) X-Received: by 2002:a17:907:a089:b0:c21:450d:cd88 with SMTP id a640c23a62f3a-c24924b8000mr2757831066b.6.1787652195293; Tue, 25 Aug 2026 03:03:15 -0700 (PDT) Received: from [192.168.188.103] (ip46-47-231-195.pool-bba.aruba.it. [195.231.47.46]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c249606b683sm1843812966b.5.2026.08.25.03.03.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Aug 2026 03:03:13 -0700 (PDT) Message-ID: <478bf88c-cb76-416d-831a-5fa7856d65ce@redhat.com> Date: Tue, 25 Aug 2026 12:03:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: mana: remove unreachable dead code in mana_bpf() To: Hamza Mahfooz , Muhammad Falak R Wani Cc: "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org References: From: Paolo Abeni Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/24/26 4:21 PM, Hamza Mahfooz wrote: > On Mon, Aug 24, 2026 at 12:39:06PM +0530, Muhammad Falak R Wani wrote: >> mana_bpf() declares an uninitialized 'ret' and falls through to a >> trailing 'return ret;' after a switch statement whose every case >> (XDP_SETUP_PROG and default) already returns unconditionally. This >> statement is therefore unreachable dead code left over from an >> earlier refactor, and it would return an uninitialized value if it >> were ever reached. >> >> Drop the unused variable and the unreachable return. >> >> Signed-off-by: Muhammad Falak R Wani > > Fixes: ed5356b53f07 ("net: mana: Add XDP support") > Reviewed-by: Hamza Mahfooz Please note that the current guidance is no fixes tag for net-next changes. Also this specific change does not address any real issue, it's just code cleanup. /P