mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zl020895  <zl020895@163.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: longzhao@ambarella.com, "Bartosz Golaszewski" <brgl@kernel.org>,
	linux-gpio@vger.kernel.org, "Linus Walleij" <linusw@kernel.org>,
	"Michael Walle" <mwalle@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Mika Westerberg" <westeri@kernel.org>,
	linux-acpi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re:Re: [PATCH v13 09/13] gpiolib: request ACPI GPIO events for external IRQ domains
Date: Wed, 4 Nov 2026 12:52:06 +0800 (CST)	[thread overview]
Message-ID: <479263db.3fa7.1a1a4e66ab1.Coremail.zl020895@163.com> (raw)
In-Reply-To: <aunMedCPibzJsfUi@ashevche-desk.local>


At 2026-11-03 19:58:49, "Andy Shevchenko" <andriy.shevchenko@linux.intel.com> wrote:
>> +	acpi_gpiochip_request_interrupts(gc);
>
>In such a case where is the freeing these requested interrupts?

Hi Andy,

gpiochip_remove() always calls gpiochip_irqchip_remove(), which frees
the ACPI events before it looks at the domain:
    gpiochip_remove()
      -> gpiochip_irqchip_remove()
           -> acpi_gpiochip_free_interrupts(gc)
           -> if (!gc->irq.domain_is_allocated_externally)
                  dispose mappings / remove domain

domain_is_allocated_externally only skips the domain teardown. The
events requested in gpiochip_irqchip_add_domain() are released on that
path. PL061 goes through it via gpio_regmap_unregister().

I will drop the duplicate Cc for Mika and move the Cc list below the
'---' marker in v14.

Best regards,
Long Zhao

  reply	other threads:[~2026-11-04  4:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  6:45 [PATCH v13 00/13] gpio: add Ambarella CV75 PL061 support Long Zhao via B4 Relay
2026-11-02  6:45 ` [PATCH v13 01/13] dt-bindings: gpio: pl061: add Ambarella CV75 variant Long Zhao via B4 Relay
2026-11-02  6:45 ` [PATCH v13 02/13] gpiolib: regmap: add GPIO_REGMAP_QUIRK_SET_AFTER_DIR Long Zhao via B4 Relay
2026-11-02  8:35   ` Michael Walle
2026-11-02  6:45 ` [PATCH v13 03/13] gpio: pl061: drop redundant pending check in the IRQ handler Long Zhao via B4 Relay
2026-11-02  6:45 ` [PATCH v13 04/13] gpio: pl061: convert register access to regmap Long Zhao via B4 Relay
2026-11-02  6:45 ` [PATCH v13 05/13] gpio: pl061: use IRQ_TYPE_LEVEL_MASK and IRQ_TYPE_EDGE_BOTH Long Zhao via B4 Relay
2026-11-02  6:45 ` [PATCH v13 06/13] gpio: pl061: use cleanup helpers for locks Long Zhao via B4 Relay
2026-11-02  6:46 ` [PATCH v13 07/13] gpio: pl061: keep the parent device in a local Long Zhao via B4 Relay
2026-11-02  6:46 ` [PATCH v13 08/13] gpio: regmap: remove gpiochip before tearing down irqchip Long Zhao via B4 Relay
2026-11-02  8:33   ` Michael Walle
2026-11-03 17:50     ` Andy Shevchenko
2026-11-04  5:00       ` zl020895
2026-11-04 14:12       ` Bartosz Golaszewski
2026-11-03 17:46   ` Andy Shevchenko
2026-11-02  6:46 ` [PATCH v13 09/13] gpiolib: request ACPI GPIO events for external IRQ domains Long Zhao via B4 Relay
2026-11-03 11:58   ` Andy Shevchenko
2026-11-04  4:52     ` zl020895 [this message]
2026-11-02  6:46 ` [PATCH v13 10/13] gpio: pl061: switch data path to gpio-regmap Long Zhao via B4 Relay
2026-11-02  6:46 ` [PATCH v13 11/13] gpio: pl061: add Ambarella register-layout variant Long Zhao via B4 Relay
2026-11-02  6:46 ` [PATCH v13 12/13] gpio: pl061: tidy up IRQ trigger logging Long Zhao via B4 Relay
2026-11-03 16:53   ` Andy Shevchenko
2026-11-02  6:46 ` [PATCH v13 13/13] gpio: pl061: use string_choices helpers for " Long Zhao via B4 Relay
2026-11-03 16:54   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479263db.3fa7.1a1a4e66ab1.Coremail.zl020895@163.com \
    --to=zl020895@163.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linusw@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longzhao@ambarella.com \
    --cc=mwalle@kernel.org \
    --cc=robh@kernel.org \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®